Skip to content

Add KeypadSim #6215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2025
Merged

Add KeypadSim #6215

merged 1 commit into from
Apr 21, 2025

Conversation

probonopd
Copy link
Contributor

@github-actions github-actions bot added the topic: modification Change existing list entry label Apr 18, 2025
Copy link
Contributor

A problem was found with your submission https://github.com/guerratron/miniFS

ERROR: Unable to load submission URL. Is the repository public?

Copy link
Contributor

Hi @probonopd.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

Copy link
Contributor

A problem was found with your submission https://github.com/probonopd/KeypadSim

ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @probonopd
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions github-actions bot requested a review from per1234 April 18, 2025 11:28
@probonopd
Copy link
Contributor Author

@ArduinoBot release created.

Copy link
Contributor

Hello! I'm checking your submission again.

Copy link
Contributor

Hi @probonopd.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot removed request for per1234 April 18, 2025 11:32
Copy link
Contributor

A problem was found with your submission https://github.com/guerratron/miniFS

ERROR: Unable to load submission URL. Is the repository public?

Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/probonopd/KeypadSim:

Linting library in KeypadSim
ERROR: Library name KeypadSim not found in the Library Manager index. Library names are not allowed to change after     
       being added to the index.                                                                                        
       See: https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name               
       (Rule LP018)                                                                                                     
WARNING: Unable to load the library.properties url field: 404 Not Found                                        
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP042)                                                                                          

Linter results for project: 1 ERRORS, 1 WARNINGS

-------------------

Linting sketch in KeypadSim/examples/KeypadController

Linter results for project: no errors or warnings

-------------------

Linting sketch in KeypadSim/examples/KeypadController_ColsPulsed

Linter results for project: no errors or warnings

-------------------

Linting sketch in KeypadSim/examples/KeypadSimDemo

Linter results for project: no errors or warnings

-------------------

Linting sketch in KeypadSim/examples/KeypadSimDemo_ColsPulsed

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 1 WARNINGS

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @probonopd
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions github-actions bot requested a review from per1234 April 18, 2025 11:33
Copy link
Contributor

Hi @probonopd.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot removed the request for review from per1234 April 18, 2025 11:37
Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/probonopd/KeypadSim:

Linting library in KeypadSim
ERROR: Library name KeypadSim not found in the Library Manager index. Library names are not allowed to change after     
       being added to the index.                                                                                        
       See: https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name               
       (Rule LP018)                                                                                                     
ERROR: Missing maintainer field in library.properties                                                        
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP025)                                                                                          

Linter results for project: 2 ERRORS, 0 WARNINGS

-------------------

Linting sketch in KeypadSim/examples/KeypadController

Linter results for project: no errors or warnings

-------------------

Linting sketch in KeypadSim/examples/KeypadController_ColsPulsed

Linter results for project: no errors or warnings

-------------------

Linting sketch in KeypadSim/examples/KeypadSimDemo

Linter results for project: no errors or warnings

-------------------

Linting sketch in KeypadSim/examples/KeypadSimDemo_ColsPulsed

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 2 ERRORS, 0 WARNINGS

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @probonopd
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions github-actions bot requested a review from per1234 April 18, 2025 11:37
@probonopd
Copy link
Contributor Author

@ArduinoBot please retest

Copy link
Contributor

Hello! I'm checking your submission again.

@per1234 per1234 self-assigned this Apr 18, 2025
Copy link
Contributor

Hi @probonopd.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/probonopd/KeypadSim:

Linting library in KeypadSim
ERROR: Library name KeypadSim not found in the Library Manager index. Library names are not allowed to change after     
       being added to the index.                                                                                        
       See: https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name               
       (Rule LP018)                                                                                                     

Linter results for project: 1 ERRORS, 0 WARNINGS

-------------------

Linting sketch in KeypadSim/examples/KeypadController

Linter results for project: no errors or warnings

-------------------

Linting sketch in KeypadSim/examples/KeypadController_ColsPulsed

Linter results for project: no errors or warnings

-------------------

Linting sketch in KeypadSim/examples/KeypadSimDemo

Linter results for project: no errors or warnings

-------------------

Linting sketch in KeypadSim/examples/KeypadSimDemo_ColsPulsed

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 0 WARNINGS

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @probonopd
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions github-actions bot requested review from per1234 and removed request for per1234 April 18, 2025 11:41
Copy link
Contributor

A problem was found with your submission https://github.com/guerratron/miniFS

ERROR: Unable to load submission URL. Is the repository public?

Copy link
Contributor

Hi @probonopd.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/probonopd/KeypadSim:

Linting library in KeypadSim
ERROR: Library name KeypadSim not found in the Library Manager index. Library names are not allowed to change after     
       being added to the index.                                                                                        
       See: https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name               
       (Rule LP018)                                                                                                     

Linter results for project: 1 ERRORS, 0 WARNINGS

-------------------

Linting sketch in KeypadSim/examples/KeypadController

Linter results for project: no errors or warnings

-------------------

Linting sketch in KeypadSim/examples/KeypadController_ColsPulsed

Linter results for project: no errors or warnings

-------------------

Linting sketch in KeypadSim/examples/KeypadSimDemo

Linter results for project: no errors or warnings

-------------------

Linting sketch in KeypadSim/examples/KeypadSimDemo_ColsPulsed

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 0 WARNINGS

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @probonopd
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions github-actions bot requested a review from per1234 April 18, 2025 11:44
@probonopd
Copy link
Contributor Author

@per1234 since this library is new, I don't know why it complains about LP018. Do I need to change something? Thanks.

@github-actions github-actions bot added topic: submission Add library to the list and removed topic: modification Change existing list entry labels Apr 18, 2025
@github-actions github-actions bot removed the request for review from per1234 April 18, 2025 13:43
Copy link
Contributor

ERROR: Your submission meets all requirements. However, the pull request could not be merged.

Please follow this guide to resolve a merge conflict:
https://docs.github.com/github/collaborating-with-issues-and-pull-requests/resolving-a-merge-conflict-on-github

Once that is done, it will be merged automatically.

@github-actions github-actions bot requested a review from per1234 April 18, 2025 13:43
@github-actions github-actions bot removed the request for review from per1234 April 21, 2025 01:10
@per1234 per1234 dismissed their stale review April 21, 2025 01:10

Requested changes have been made. Thanks!

@github-actions github-actions bot merged commit 69d9e76 into arduino:main Apr 21, 2025
11 checks passed
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/probonopd/KeypadSim/

github-actions bot pushed a commit that referenced this pull request Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants