Skip to content

Commit 36517b3

Browse files
committed
uuid models support for nesting modules
1 parent 85b6719 commit 36517b3

File tree

8 files changed

+18
-18
lines changed

8 files changed

+18
-18
lines changed

src/Http/Controllers/Admin/AppSettingsController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ protected function setUpController(): void
3333
}
3434
}
3535

36-
public function update(int|string|TwillModelContract $id, ?int $submoduleId = null): JsonResponse
36+
public function update(int|string|TwillModelContract $id, int|string|null $submoduleId = null): JsonResponse
3737
{
3838
$model = AppSetting::findOrFail($id);
3939

src/Http/Controllers/Admin/FileLibraryController.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ public function filters(): TableFilters
106106
]);
107107
}
108108

109-
public function index(?int $parentModuleId = null): mixed
109+
public function index(int|string|null $parentModuleId = null): mixed
110110
{
111111
if ($this->request->has('except')) {
112112
$prependScope['exceptIds'] = $this->request->get('except');
@@ -172,7 +172,7 @@ protected function getRequestFilters(): array
172172
}
173173

174174
/**
175-
* @param int|null $parentModuleId
175+
* @param int|string|null $parentModuleId
176176
* @return JsonResponse
177177
* @throws BindingResolutionException
178178
*/

src/Http/Controllers/Admin/GroupController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ public function edit(int|string|TwillModelContract $id): mixed
100100
return parent::edit($id);
101101
}
102102

103-
public function update(int|string|TwillModelContract $id, ?int $submoduleId = null): JsonResponse
103+
public function update(int|string|TwillModelContract $id, int|string|null $submoduleId = null): JsonResponse
104104
{
105105
$this->authorizableOptions['edit'] = 'edit-group';
106106

src/Http/Controllers/Admin/MediaLibraryController.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ public function filters(): TableFilters
106106
]);
107107
}
108108

109-
public function index(?int $parentModuleId = null): array
109+
public function index(int|string|null $parentModuleId = null): array
110110
{
111111
if ($this->request->has('except')) {
112112
$prependScope['exceptIds'] = $this->request->get('except');
@@ -150,7 +150,7 @@ protected function getRequestFilters(): array
150150
}
151151

152152
/**
153-
* @param int|null $parentModuleId
153+
* @param int|string|null $parentModuleId
154154
* @return
155155
*/
156156
public function store($parentModuleId = null)

src/Http/Controllers/Admin/ModuleController.php

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ abstract class ModuleController extends Controller
259259
protected $submodule = false;
260260

261261
/**
262-
* @var int|null
262+
* @var int|string|null
263263
*/
264264
protected $submoduleParentId = null;
265265

@@ -970,7 +970,7 @@ protected function getParentModuleIdFromRequest(Request $request)
970970
/**
971971
* @return IlluminateView|JsonResponse
972972
*/
973-
public function index(?int $parentModuleId = null): mixed
973+
public function index(int|string|null $parentModuleId = null): mixed
974974
{
975975
$this->authorizeOption('list', $this->moduleName);
976976

@@ -1032,7 +1032,7 @@ public function browser(): JsonResponse
10321032
}
10331033

10341034
/**
1035-
* @param int|null $parentModuleId
1035+
* @param int|string|null $parentModuleId
10361036
* @return \Illuminate\Http\JsonResponse
10371037
*/
10381038
public function store($parentModuleId = null)
@@ -1093,7 +1093,7 @@ public function store($parentModuleId = null)
10931093
/**
10941094
* @param Request $request
10951095
* @param int|string $id
1096-
* @param int|null $submoduleId
1096+
* @param int|string|null $submoduleId
10971097
* @return \Illuminate\Http\RedirectResponse
10981098
*/
10991099
public function show($id, $submoduleId = null)
@@ -1169,7 +1169,7 @@ public function edit(TwillModelContract|int|string $id): mixed
11691169
);
11701170
}
11711171

1172-
public function create(int $parentModuleId = null): JsonResponse|RedirectResponse|IlluminateView
1172+
public function create(int|string $parentModuleId = null): JsonResponse|RedirectResponse|IlluminateView
11731173
{
11741174
if (! $this->getIndexOption('skipCreateModal')) {
11751175
return Redirect::to(
@@ -1205,7 +1205,7 @@ public function create(int $parentModuleId = null): JsonResponse|RedirectRespons
12051205
);
12061206
}
12071207

1208-
public function update(int|string|TwillModelContract $id, ?int $submoduleId = null): JsonResponse
1208+
public function update(int|string|TwillModelContract $id, int|string|null $submoduleId = null): JsonResponse
12091209
{
12101210
[$item, $id] = $this->itemAndIdFromRequest($id);
12111211

@@ -1435,7 +1435,7 @@ public function bulkPublish(): JsonResponse
14351435
);
14361436
}
14371437

1438-
public function duplicate(int|string|TwillModelContract $id, ?int $submoduleId = null): JsonResponse
1438+
public function duplicate(int|string|TwillModelContract $id, int|string|null $submoduleId = null): JsonResponse
14391439
{
14401440
[$item, $id] = $this->itemAndIdFromRequest($id);
14411441

@@ -1475,7 +1475,7 @@ public function duplicate(int|string|TwillModelContract $id, ?int $submoduleId =
14751475
);
14761476
}
14771477

1478-
public function destroy(int|string|TwillModelContract $id, ?int $submoduleId = null): JsonResponse
1478+
public function destroy(int|string|TwillModelContract $id, int|string|null $submoduleId = null): JsonResponse
14791479
{
14801480
[$item, $id] = $this->itemAndIdFromRequest($id);
14811481

src/Http/Controllers/Admin/RoleController.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ protected function indexItemData($item): array
8787
return ['edit' => $canEdit ? $this->getModuleRoute($item->id, 'edit') : null];
8888
}
8989

90-
public function index(?int $parentModuleId = null): mixed
90+
public function index(int|string|null $parentModuleId = null): mixed
9191
{
9292
// Superadmins can reorder groups to determine the access-level of each one.
9393
// A given group can't edit other groups with a higher access-level.
@@ -103,7 +103,7 @@ public function edit(int|string|TwillModelContract $id): mixed
103103
return parent::edit($id);
104104
}
105105

106-
public function update(int|string|TwillModelContract $id, ?int $submoduleId = null): JsonResponse
106+
public function update(int|string|TwillModelContract $id, int|string|null $submoduleId = null): JsonResponse
107107
{
108108
$this->authorizableOptions['edit'] = 'edit-role';
109109

src/Http/Controllers/Admin/SingletonModuleController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ abstract class SingletonModuleController extends ModuleController
1111
{
1212
protected $permalinkBase = '';
1313

14-
public function index(?int $parentModuleId = null): mixed
14+
public function index(int|string|null $parentModuleId = null): mixed
1515
{
1616
throw new \Exception("{$this->getModelName()} has no index");
1717
}

src/Http/Controllers/Admin/UserController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -296,7 +296,7 @@ public function edit(int|string|TwillModelContract $id): mixed
296296
return parent::edit($id);
297297
}
298298

299-
public function update(int|string|TwillModelContract $id, ?int $submoduleId = null): JsonResponse
299+
public function update(int|string|TwillModelContract $id, int|string|null $submoduleId = null): JsonResponse
300300
{
301301
$this->authorizableOptions['edit'] = 'edit-user';
302302

0 commit comments

Comments
 (0)