Add warning during update/build for new migrations introduced in 3.5.0

Author: ifox

src/Commands/Build.php

@@ -3,12 +3,14 @@
 namespace A17\Twill\Commands;
 
 use A17\Twill\Commands\Traits\ExecutesInTwillDir;
+use A17\Twill\Commands\Traits\HandlesPotentialBreakingChangesWarnings;
 use Illuminate\Filesystem\Filesystem;
 use Symfony\Component\Process\Process;
 
 class Build extends Command
 {
     use ExecutesInTwillDir;
+    use HandlesPotentialBreakingChangesWarnings;
 
     /**
      * The name and signature of the console command.
@@ -37,6 +39,8 @@ public function __construct(public Filesystem $filesystem)
      */
     public function handle(): void
     {
+        $this->warnAboutNewPositionColumns();
+
         if ($this->option('copyOnly')) {
             $this->copyCustoms();
 

src/Commands/Traits/HandlesPotentialBreakingChangesWarnings.php

@@ -0,0 +1,29 @@
+<?php
+
+namespace A17\Twill\Commands\Traits;
+
+use Illuminate\Support\Facades\Schema;
+
+/* @mixin \Illuminate\Console\Command */
+trait HandlesPotentialBreakingChangesWarnings
+{
+    public function warnAboutNewPositionColumns(): void
+    {
+        if (config('twill.load_default_migrations', true)) {
+            return;
+        }
+
+        $mediablesHasPosition = Schema::hasColumn(config('twill.mediables_table', 'twill_mediables'), 'position');
+        $fileablesHasPosition = Schema::hasColumn(config('twill.fileables_table', 'twill_fileables'), 'position');
+
+        if ($mediablesHasPosition && $fileablesHasPosition) {
+            return;
+        }
+
+        $this->warn('⚠️  Twill 3.5.0 introduced 2 new database migrations to fix a bug with the medias and files fields position management, make sure to add them to your project.');
+        $this->warn("\nAdd position field to the twill_mediables table:");
+        $this->info("🔗 https://github.com/area17/twill/blob/3.5.0/migrations/default/2020_02_09_000015_add_position_to_twill_default_mediables_table.php");
+        $this->warn("\nAdd position field to the twill_fileables table:");
+        $this->info("🔗 https://github.com/area17/twill/blob/3.5.0/migrations/default/2020_02_09_000016_add_position_to_twill_default_fileables_table.php");
+    }
+}

src/Commands/Update.php

@@ -2,10 +2,13 @@
 
 namespace A17\Twill\Commands;
 
+use A17\Twill\Commands\Traits\HandlesPotentialBreakingChangesWarnings;
 use Illuminate\Filesystem\Filesystem;
 
 class Update extends Command
 {
+    use HandlesPotentialBreakingChangesWarnings;
+
     protected $signature = 'twill:update {--fromBuild} {--migrate}';
     protected $description = 'Publish new updated Twill assets and optionally run database migrations';
 
@@ -19,6 +22,9 @@ public function handle(): void
         $this->publishAssets();
         $this->call('twill:flush-manifest');
         $this->call('view:clear');
+
+        $this->warnAboutNewPositionColumns();
+
         if ($this->option('migrate') || $this->confirm('Do you want to run any pending database migrations now?')) {
             $this->call('migrate');
         }