Replace phpcs with laravel/pint #2499
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tofandel
force-pushed
the
replace-phpcs-with-pint
branch
2 times, most recently
from
636827b to
2d1ccc9
Compare
Tofandel
force-pushed
the
replace-phpcs-with-pint
branch
from
2d1ccc9 to
438c320
Compare
Member
|
I'm open to do this, thanks for suggesting it. I will ping you when it is ready to rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that pint is the standard for laravel project, it would be nice to switch to it, it uses phpcs under the hood but with an extensive set of rules
It really homogenizes the code and removes all the unused imports/variables
I added cghooks so that any code committed (with the project installed with composer) will automatically get pinted while committing
I'm aware that's a big diff and I can resubmit it without the diff if you prefer to apply it separatly (but tests will fail)
I also suggest to merge a maximum of PR first and I can rebase this PR to avoid conflicts with existing PRs