Unify benchmarks from whisperkittools#18
Merged
EduardoPach merged 3 commits intomainfrom Jul 21, 2025
Merged
Conversation
atiorh
approved these changes
Jul 21, 2025
Contributor
atiorh
left a comment
There was a problem hiding this comment.
Looks great - 1 NIT comment
arda-argmax
reviewed
Jul 21, 2025
Contributor
arda-argmax
left a comment
There was a problem hiding this comment.
LGTM! ✅
Suggestions for future improvement:
- We can add support for additional pipelines available in
whisperkittools, such as WhisperCPP and WhisperMLX. - It might also be helpful to enable support for local/custom models within the
WhisperKitTranscriptionPipeline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR serves as the first step to unify the benchmarks once done in whisperkittools to
SDBenchby adding some pipelines that were only inwhisperkittools, and adding support for the main datasets used inwhisperkittoolsWhisperKitand Apple'sSpeechAnalyzeras pipelinescommon-voice,librispeech, andearnings22