Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Observers and checkpointing are missing tests #474

Open
3 tasks
stefan-k opened this issue Feb 28, 2024 · 0 comments
Open
3 tasks

Observers and checkpointing are missing tests #474

stefan-k opened this issue Feb 28, 2024 · 0 comments
Labels
argmin-checkpointing-file Anything related to the argmin-checkpointing-file crate argmin-observer-paramwriter Anything related to the argmin-observer-paramwriter crate argmin-observer-slog Anything related to the argmin-observer-slog crate good first issue Good for newcomers

Comments

@stefan-k
Copy link
Member

I just noticed that the observers and checkpointing are missing tests. Checkpointing does have a test, but it doesn't check whether the loaded checkpoint is equivalent to the saved checkpoint.

  • Add tests for argmin-observer-slog
  • Add tests for argmin-observer-paramwriter
  • Add tests for argmin-checkpointing-file
@stefan-k stefan-k added good first issue Good for newcomers argmin-observer-slog Anything related to the argmin-observer-slog crate argmin-observer-paramwriter Anything related to the argmin-observer-paramwriter crate argmin-checkpointing-file Anything related to the argmin-checkpointing-file crate labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
argmin-checkpointing-file Anything related to the argmin-checkpointing-file crate argmin-observer-paramwriter Anything related to the argmin-observer-paramwriter crate argmin-observer-slog Anything related to the argmin-observer-slog crate good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stefan-k