Default github api url

[FestineOnGCP]

Hi everyone,

I have been using argocd image updater for more than a year now and the product has been great.
Kudos to everyone who has made this a success.

However, I'm trying to use argocd image updater to authenticate with a github application secret. On the logs I see that the github api url is https://api.github.com/app/installations/$MY_INSTALLATION_ID/access_token. How can I change this default github api url to point to a githubAppEnterpriseBaseUrl (that is an enterprise github api url)?

I'll greatly appreciate it if I can get a feedback soon.
Thank you.

[chengfang]

looks like it's fixed to https://api.github.com: https://github.com/argoproj-labs/argocd-image-updater/blob/master/ext/git/creds.go#L447

What's your desired baseUrl look like?

I think we can obtain the api base url based on the repo url, to cover both public and enterprise github repo.

[chengfang]

I think with some extra configuration, a custom github enterprise base url should arleady be supported.

You can add a repository via either argocd CLI or web ui, specifying github-app-enterprise-base-url. This way your application repo is associated with the right api base url, and the default base url will not be applied.

  argocd repo add -h

  # Add a private Git repository on GitHub Enterprise via GitHub App
  argocd repo add https://ghe.example.com/repos/repo --github-app-id 1 --github-app-installation-id 2 --github-app-private-key-path test.private-key.pem --github-app-enterprise-base-url https://ghe.example.com/api/v3

[FestineOnGCP]

This will not fit our use case. Argocd itself could pick the enterprise api url from the github app secret yaml file. The base enterprise api url is present under the field "githubAppEnterpriseBaseUrl". I think the g.baseUrl was supposed to pick up this value but it is not picking it up. The workaround we have for the now is just to change the default baseUrl to our enterprise api url on the cred.go file and build the image from the Dockerfile. Please, do let me know when this feature is implemented.

[chengfang]

#1058 attempts to fix it by deriving base url from repo url. Will that work?

[FestineOnGCP]

yea. this might work

[FestineOnGCP]

could we get this from the github app secret?

[chengfang]

image-updater queries argocd db to obtain the repository by its url: https://github.com/argoproj-labs/argocd-image-updater/blob/master/pkg/argocd/gitcreds.go#L41

then it creates its own creds structure based on all the data in the above repo from argocd, including the enterprise api base url: https://github.com/argoproj-labs/argocd-image-updater/blob/master/pkg/argocd/gitcreds.go#L67

so all repo params configured in argocd should also be picked up by image-updater, in theory.