-
Notifications
You must be signed in to change notification settings - Fork 317
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Describe the bug
When user sends a webhook request with non-existing type it returns incorrect error message.
To Reproduce
- Set up webhook server (in my example on localhost)
- Send a request with non-existing type
curl -X POST \
-H "Content-Type: application/json" \
-d '{
"specversion": "1.0",
"id": "1",
"type": "image",
...
}
}' \
"http://localhost:8080/webhook?type=doesntexist"
repository name not found in webhook payload
- Send the same request again and see error message
no tags in the payload
- and again
unsupported event type: image
- again - the worst case
Webhook received and processing
Expected behavior
Show a clear error message and stop execution.
Additional context
Add any other context about the problem here.
Version
1.0.1
0.17
Regression
Does this issue apply to (check all that apply):
- Annotation-based configuration (versions starting with
0, e.g.,0.17.0) - CRD-based configuration (versions starting with
1, e.g.,1.0.0)
chengfang
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working