Skip to content

Consider replacing autoMerge boolean with enum #281

Open
@crenshaw-dev

Description

@crenshaw-dev

Was reading through k8s API conventions and came across this:

Think twice about bool fields. Many ideas start as boolean but eventually trend towards a small set of mutually exclusive options. Plan for future expansions by describing the policy options explicitly as a string type alias (e.g. TerminationMessagePolicy).

It's a good point. Should we consider something like mergePolicy, mergeStrategy, etc.? Maybe mergePolicy: OnCommitStatusPassed and mergePolicy: Manual.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions