Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ConnMaxIdleTime in redis-client #22489

Open
OpenGuidou opened this issue Mar 26, 2025 · 0 comments · May be fixed by #22490
Open

Support ConnMaxIdleTime in redis-client #22489

OpenGuidou opened this issue Mar 26, 2025 · 0 comments · May be fixed by #22490
Labels
enhancement New feature or request

Comments

@OpenGuidou
Copy link
Contributor

Summary

It is not possible today to set the ConnMaxIdleTime for argocd controllers using the redis client.

Motivation

The default duration that go redis client keeps an idle connection in its pool is 30min.
When using redis servers with a timeout value lower than that (and it's the fact for example for redis-ha with the default values), connections are terminated by the server and we end up with error in Argo CD such as broken pipe.

Proposal

This change would introduce the support for this option via the CLI and deployment manifests.

@OpenGuidou OpenGuidou added the enhancement New feature or request label Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant