Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(anta): Refactor the VerifyBFDPeersIntervals test to add detection time #858

Merged
merged 5 commits into from
Jan 8, 2025
Merged

refactor(anta): Refactor the VerifyBFDPeersIntervals test to add detection time #858

merged 5 commits into from
Jan 8, 2025

Conversation

vitthalmagadum
Copy link
Collaborator

Description

Verifies the timers of the IPv4 BFD peers in the specified VRF.

Expected Results
----------------
* Success: The test will pass if the timers of the IPv4 BFD peers are correct in the specified VRF.
* Failure: The test will fail if the IPv4 BFD peers are not found or their timers are incorrect in the specified VRF.

Fixes #857

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 8, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #858 will not alter performance

Comparing vitthalmagadum:issue_857 (06d0de8) with main (1f033f4)

Summary

✅ 22 untouched benchmarks

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

carl-baillargeon
carl-baillargeon requested changes Jan 7, 2025
View reviewed changes
anta/input_models/bfd.py Outdated Show resolved Hide resolved
anta/tests/bfd.py Show resolved Hide resolved
@carl-baillargeon carl-baillargeon mentioned this pull request Jan 7, 2025
Open
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

carl-baillargeon
carl-baillargeon approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@carl-baillargeon carl-baillargeon merged commit d21e443 into aristanetworks:main Jan 8, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carl-baillargeon carl-baillargeon carl-baillargeon approved these changes

Assignees

@vitthalmagadum vitthalmagadum

Labels
rn: refactor(anta)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor the VerifyBFDPeersIntervals test to verify the detection time.
2 participants
@vitthalmagadum @carl-baillargeon