Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(anta): Added testcase to validate the STP disabled VLANs #972

Merged
merged 5 commits into from
Dec 31, 2024
Merged

feat(anta): Added testcase to validate the STP disabled VLANs #972

merged 5 commits into from
Dec 31, 2024

Conversation

geetanjalimanegslab
Copy link
Collaborator

@geetanjalimanegslab geetanjalimanegslab commented Dec 19, 2024 •
edited by carl-baillargeon
Loading

Description

This test performs the following checks:
1. Verifies that the STP is configured.
2. Verifies that the specified VLAN is present on the device.
3. Verifies that the STP is disabled for the specified VLANs.

Expected Results
----------------
* Success: The test will pass if STP is disabled for the specified VLANs.
* Failure: The test will fail, if STP is enabled for the specified VLANs

Fixes #862

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 19, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #972 will not alter performance

Comparing geetanjalimanegslab:test_stp_enablment (4ecf530) with main (2a0bf6c)

Summary

✅ 22 untouched benchmarks

vitthalmagadum
vitthalmagadum requested changes Dec 24, 2024
View reviewed changes
anta/tests/stp.py Outdated Show resolved Hide resolved
anta/tests/stp.py Outdated Show resolved Hide resolved
anta/tests/stp.py Outdated Show resolved Hide resolved
vitthalmagadum
vitthalmagadum approved these changes Dec 30, 2024
View reviewed changes
Copy link
Collaborator

@vitthalmagadum vitthalmagadum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update succes and failure in docstring.

@vitthalmagadum vitthalmagadum marked this pull request as ready for review December 30, 2024 16:44
vitthalmagadum
vitthalmagadum approved these changes Dec 31, 2024
View reviewed changes
Copy link
Collaborator

@vitthalmagadum vitthalmagadum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

carl-baillargeon
carl-baillargeon approved these changes Dec 31, 2024
View reviewed changes
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will push some minor changes to docstrings. Thank you

anta/tests/stp.py Outdated Show resolved Hide resolved
anta/tests/stp.py Outdated Show resolved Hide resolved
anta/tests/stp.py Outdated Show resolved Hide resolved
anta/tests/stp.py Outdated Show resolved Hide resolved
tests/units/anta_tests/test_stp.py Outdated Show resolved Hide resolved
tests/units/anta_tests/test_stp.py Outdated Show resolved Hide resolved
tests/units/anta_tests/test_stp.py Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@carl-baillargeon carl-baillargeon merged commit a5a93b7 into aristanetworks:main Dec 31, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitthalmagadum vitthalmagadum vitthalmagadum approved these changes

@carl-baillargeon carl-baillargeon carl-baillargeon approved these changes

@gmuloc gmuloc Awaiting requested review from gmuloc

Assignees

@geetanjalimanegslab geetanjalimanegslab

Labels
rn: feat(anta)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the test case to verify whether STP is enabled or disabled for the specific vlan
3 participants
@geetanjalimanegslab @carl-baillargeon @vitthalmagadum