feat(anta): Added test case to verify dynamic vlans source #978
+87
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geetanjalimanegslab
changed the title
geetanjalimanegslab
changed the title
geetanjalimanegslab
changed the title
|
CodSpeed Performance ReportMerging #978 will not alter performanceComparing Summary
|
vitthalmagadum
requested changes
Dec 24, 2024
| This test performs the following checks for each specified routerpath: | ||
| 1. Verifies that the dynamic VLANs are configured. | ||
| 2. Verifies that the dynamic VLANs are active only within the expected source. | ||
| Expected Results |
There was a problem hiding this comment.
Please check the documentation(mkdocs) to ensure it highlights the expected results.
| dynamic_vlans = command_output.get("dynamicVlans", {}) | ||
|
|
||
| actual_source = [source for source, data in dynamic_vlans.items() if data.get("vlanIds")] | ||
| # If the dynamic vlans are not configured, test fails. |
There was a problem hiding this comment.
skipping the test.
|
|
||
| expected_source = self.inputs.source | ||
| # If dynamic VLANs are not active for specified source, test fails | ||
| if not set(actual_source).issubset(expected_source): |
There was a problem hiding this comment.
It should be exact match, right?
Comment on lines
+79
to
+80
| 1. Verifies that the dynamic VLANs are configured. | ||
| 2. Verifies that the dynamic VLANs are active only within the expected source. |
There was a problem hiding this comment.
Suggested change
| 1. Verifies that the dynamic VLANs are configured. | |
| 2. Verifies that the dynamic VLANs are active only within the expected source. | |
| 1. Ensures that dynamic VLANs are properly configured in the system. | |
| 2. Confirms that dynamic VLANs are active only within their designated sources. |
| expected_source = self.inputs.source | ||
| # If dynamic VLANs are not active for specified source, test fails | ||
| if not set(actual_source).issubset(expected_source): | ||
| self.result.is_failure(f"Incorrect source for dynamic VLANs - Expected: {expected_source} Actual: {actual_source}") |
There was a problem hiding this comment.
Suggested change
| self.result.is_failure(f"Incorrect source for dynamic VLANs - Expected: {expected_source} Actual: {actual_source}") | |
| self.result.is_failure(f"Dynamic VLANs are not restricted to given sources - Expected: ', '.join(expected_source)} Actual: {', '.join(actual_source)}") |
There was a problem hiding this comment.
Please check csv reports.
| """Input model for the VerifyDynamicVlanSource test.""" | ||
|
|
||
| model_config = ConfigDict(extra="forbid") | ||
| source: list[str] |
There was a problem hiding this comment.
We may restrict the sources. Also do we really need extra="forbid" ?
| "test": VerifyDynamicVlanSource, | ||
| "eos_data": [{"dynamicVlans": {"vccbfd": {"vlanIds": [1500]}, "mlagsync": {"vlanIds": [1501]}}}], | ||
| "inputs": {"source": ["evpn", "mlagsync"]}, | ||
| "expected": {"result": "failure", "messages": ["Incorrect source for dynamic VLANs - Expected: ['evpn', 'mlagsync'] Actual: ['vccbfd', 'mlagsync']"]}, |
There was a problem hiding this comment.
We avoid use of lists, dicts inside the string.
| "name": "success-singal-source-found", | ||
| "test": VerifyDynamicVlanSource, | ||
| "eos_data": [{"dynamicVlans": {"evpn": {"vlanIds": [1199]}, "mlagsync": {"vlanIds": []}}}], | ||
| "inputs": {"source": ["evpn", "mlagsync"]}, |
There was a problem hiding this comment.
I do not see any dynamic VLANs with the input source mlagsync, yet the test passes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This test performs the following checks for each specified:
1. Verifies that the dynamic VLANs are configured.
2. Verifies that the dynamic VLANs are active only within the expected source.
Expected Results
----------------
* Success: The test will pass if the dynamic VLANs are active only within the expected source.
* Failure: The test will fail if the dynamic VLANs are not active within the expected source or activated in other sources.
Fixes #864
Checklist:
pre-commit run)tox -e testenv)