Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilise Web Routing API #111

Open
2 tasks
arkivanov opened this issue May 18, 2022 · 12 comments
Open
2 tasks

Stabilise Web Routing API #111

arkivanov opened this issue May 18, 2022 · 12 comments

Comments

@arkivanov
Copy link
Owner

arkivanov commented May 18, 2022

Docs: link. Collection feedback and use cases here.

Points to improve:

  • Consider moving WebHistoryController from commonMain to jsMain
  • Consider nested WebHistoryController
@arkivanov arkivanov mentioned this issue May 18, 2022
14 tasks
@NorbertSandor
Copy link

FYI, the link is dead.

@arkivanov
Copy link
Owner Author

FYI, the link is dead.

Thanks, updated the link.

@plusmobileapps
Copy link
Contributor

The example links in that doc seem to also be dead links pointing to the wrong path?

@arkivanov
Copy link
Owner Author

arkivanov commented Jul 24, 2022

@arkivanov
Copy link
Owner Author

The links should be fixed now.

@arkivanov
Copy link
Owner Author

This will stay experimental for a while.

@arkivanov arkivanov closed this as not planned Won't fix, can't repro, duplicate, stale Feb 3, 2023
@Burtan
Copy link

Burtan commented Sep 8, 2024

Is there any open discussion about WebHistoryController?

@arkivanov
Copy link
Owner Author

Is there any open discussion about WebHistoryController?

I don't remember any discussion. The WebHistoryController doesn't support nested navigation, I wanted to try doing something with it but didn't have time yet.

@Burtan
Copy link

Burtan commented Sep 8, 2024

I think nested navigation is very much needed for bigger web applications. If this is open for discussion I'll collect my thoughts about it :-).

@arkivanov
Copy link
Owner Author

Sure, feel free!

@arkivanov arkivanov reopened this Sep 8, 2024
@chrisjenx
Copy link

Don't think it's super critical, but for sure nice to have, we don't store tabs sub navigation, it gets blown away when switching top level tabs. But I'm guessing htere may be cases where that is wanted

@arkivanov
Copy link
Owner Author

it gets blown away when switching top level tabs

I think this shouldn't normally happen. Only if you restart the session. The root instance shouldn't recreating when you navigate normally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants