[#910] Remove Scaledown CRD #911
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brusdev
requested changes
Apr 29, 2024
There was a problem hiding this comment.
Great cleanup!
The only blocker is a release that includes artemiscloud@d7babc9
| @@ -40,125 +35,86 @@ var controllers map[string]*draincontroller.Controller = make(map[string]*drainc | |||
|
|
|||
| var kubeClient *kubernetes.Clientset | |||
|
|
|||
| // ActiveMQArtemisScaledownReconciler reconciles a ActiveMQArtemisScaledown object | |||
| type ActiveMQArtemisScaledownReconciler struct { | |||
| type ActiveMQArtemisMessageMigrationControl struct { | |||
There was a problem hiding this comment.
The filename is still activemqartemisscaledown_controller.go
There was a problem hiding this comment.
yeah it should be renamed. Good catch!
There was a problem hiding this comment.
changed it to draft. It's a major change we should try not be included in minor releases.
gaohoward
force-pushed
the
remove_scaledown_crd
branch
from
efc57af to
931bf99
Compare
|
This project is now part of the ArkMQ initiative. This repository has been archived as all activities are now happening in the corresponding ArkMQ repository. See here for the ArkMQ transition details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.