improve type error for trailing finalizer (#1342)

Author: ssalbdivad

ark/attest/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@ark/attest",
-	"version": "0.44.0",
+	"version": "0.44.1",
 	"license": "MIT",
 	"author": {
 		"name": "David Blass",

ark/docs/content/docs/expressions/index.mdx

@@ -417,40 +417,6 @@ const parseEvenSugared = type("string.numeric.parse", "|>", "number % 2")
 
 </SyntaxTabs>
 
-### Morph
-
-Morphs allow you to transform your data after it is validated. You can read more about them in [their intro section](/docs/intro/morphs-and-more/).
-
-<SyntaxTabs>
-    <SyntaxTab fluent>
-
-```ts
-// hover to see how morphs are represented at a type-level
-const trimStringStart = type("string").pipe(str => str.trimStart())
-```
-
-    </SyntaxTab>
-
-    <SyntaxTab tuple>
-
-```ts
-// hover to see how morphs are represented at a type-level
-const trimStringStart = type(["string", "=>", str => str.trimStart()])
-```
-
-    </SyntaxTab>
-
-    <SyntaxTab args>
-
-```ts
-// hover to see how morphs are represented at a type-level
-const trimStringStart = type("string", "=>", str => str.trimStart())
-```
-
-    </SyntaxTab>
-
-</SyntaxTabs>
-
 ### Unit
 
 While embedded [literal syntax](/docs/primitives#number-literals) is usually ideal for defining exact primitive values, `===` and `type.unit` can be helpful for referencing a non-serialiazable value like a `symbol` from your type.

ark/fs/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@ark/fs",
-	"version": "0.44.0",
+	"version": "0.44.1",
 	"license": "MIT",
 	"author": {
 		"name": "David Blass",

ark/repo/scratch.ts

@@ -1,13 +1,7 @@
 import { type } from "arktype"
 
-const t = type({
-	/** FOO */
-	foo: "string",
-	/** BAR */
-	bar: "number?"
+export const urDOOMed = type({
+	grouping: "(0 | (1 | (2 | (3 | (4 | 5)[])[])[])[])[]",
+	nestedGenerics: "Exclude<0n | unknown[] | Record<string, unknown>, object>",
+	"escapes\\?": "'a | b' | 'c | d'"
 })
-
-const out = t.assert({ foo: "foo" })
-
-out.foo
-out.bar

ark/schema/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@ark/schema",
-	"version": "0.44.0",
+	"version": "0.44.1",
 	"license": "MIT",
 	"author": {
 		"name": "David Blass",

ark/type/__tests__/enclosed.test.ts

@@ -46,11 +46,15 @@ contextualize(() => {
 	})
 
 	it("double-quoted", () => {
-		attest<"goodbye">(type('"goodbye"').infer)
+		const t = type('"goodbye"')
+		attest<"goodbye">(t.infer)
+		attest(t.expression).snap('"goodbye"')
 	})
 
 	it("regex literal", () => {
-		attest<string>(type("/.*/").infer)
+		const t = type("/.*/")
+		attest<string>(t.infer)
+		attest(t.expression).snap("string /.*/")
 	})
 
 	it("invalid regex", () => {
@@ -60,21 +64,30 @@ contextualize(() => {
 	})
 
 	it("mixed quote types", () => {
-		attest<"'single-quoted'">(type(`"'single-quoted'"`).infer)
-		attest<'"double-quoted"'>(type(`'"double-quoted"'`).infer)
+		const t = type(`"'single-quoted'"`)
+		attest<"'single-quoted'">(t.infer)
+		attest(t.expression).snap("\"'single-quoted'\"")
+
+		const u = type(`'"double-quoted"'`)
+		attest<'"double-quoted"'>(u.infer)
 	})
 
 	it("ignores enclosed operators", () => {
-		attest<"yes|no|maybe">(type("'yes|no|maybe'").infer)
+		const t = type("'yes|no|maybe'")
+		attest<"yes|no|maybe">(t.infer)
+		attest(t.expression).snap('"yes|no|maybe"')
 	})
 
 	it("mix of enclosed and unenclosed operators", () => {
-		attest<"yes|no" | "true|false">(type("'yes|no'|'true|false'").infer)
+		const t = type("'yes|no'|'true|false'")
+		attest<"yes|no" | "true|false">(t.infer)
+		attest(t.expression).snap('"true|false" | "yes|no"')
 	})
 
 	it("escaped enclosing", () => {
 		const t = type("'don\\'t'")
 		attest<"don't">(t.infer)
+		attest(t.expression).snap('"don\'t"')
 	})
 
 	it("string literal stress", () => {

ark/type/__tests__/generic.test.ts

@@ -622,7 +622,7 @@ contextualize(() => {
 					}
 				}).export()
 			).type.errors.snap(
-				'Type \'"nest"\' is not assignable to type \'"Unexpectedly failed to parse the expression resulting from ... " & { ast: GenericAst<[["t", unknown]], { readonly nest: "nest"; }, "$", "$">; }\'.Type \'"nest"\' is not assignable to type \'"Unexpectedly failed to parse the expression resulting from ... "\'.'
+				'Type \'"nest"\' is not assignable to type \'"Failed to parse the expression resulting from ... " & { ast: GenericAst<[["t", unknown]], { readonly nest: "nest"; }, "$", "$">; }\'.Type \'"nest"\' is not assignable to type \'"Failed to parse the expression resulting from ... "\'.'
 			)
 		})
 	})

ark/type/package.json

@@ -1,7 +1,7 @@
 {
 	"name": "arktype",
 	"description": "Optimized runtime validation for TypeScript syntax",
-	"version": "2.1.5",
+	"version": "2.1.6",
 	"license": "MIT",
 	"repository": {
 		"type": "git",

ark/type/parser/ast/validate.ts

@@ -64,7 +64,7 @@ export type validateAst<ast, $, args> =
 		}
 
 type writeUnexpectedExpressionMessage<expression extends string> =
-	`Unexpectedly failed to parse the expression resulting from ${expression}`
+	`Failed to parse the expression resulting from ${expression}`
 
 export const writePrefixedPrivateReferenceMessage = <name extends string>(
 	name: name

ark/type/parser/string.ts

@@ -114,4 +114,4 @@ export type extractFinalizedResult<s extends StaticState> =
 	: s["finalizer"] extends ErrorMessage ? s["finalizer"]
 	: s["finalizer"] extends "?" ? [s["root"], "?"]
 	: s["finalizer"] extends "=" ? parseDefault<s["root"], s["unscanned"]>
-	: state.error<writeUnexpectedCharacterMessage<`${s["finalizer"]}`>>
+	: ErrorMessage<writeUnexpectedCharacterMessage<s["finalizer"] & string>>