fix jitless object transformations (#1339)

Author: ssalbdivad

ark/attest/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@ark/attest",
-	"version": "0.43.2",
+	"version": "0.43.3",
 	"license": "MIT",
 	"author": {
 		"name": "David Blass",

ark/fs/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@ark/fs",
-	"version": "0.43.2",
+	"version": "0.43.3",
 	"license": "MIT",
 	"author": {
 		"name": "David Blass",

ark/repo/scratch.ts

@@ -1,27 +1,12 @@
 import { type } from "arktype"
 
-// Define environment variable requirements
-const environmentSchema = type({
-	DATA_PATH: "string = './data'"
-})
-
-const base = {
-	get foo() {
-		return "foo"
-	}
-}
-
-// Validate environment variables
-console.info("🔧 Parsing environment variables...")
-const result = environmentSchema(process.env)
-
-// Exit if validation fails
-if (result instanceof type.errors) {
-	console.error(result.summary)
-	console.error("process exited with error code 1")
-	process.exit(1)
-}
-
-// Export validated environment
-const environment = result
-export { environment }
+const types = type.module(
+	{
+		foo: {
+			test: "string = 'test'"
+		}
+	},
+	{ jitless: true }
+)
+
+types.foo({}) //?

ark/schema/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@ark/schema",
-	"version": "0.43.2",
+	"version": "0.43.3",
 	"license": "MIT",
 	"author": {
 		"name": "David Blass",

ark/schema/structure/structure.ts

@@ -555,50 +555,50 @@ export class StructureNode extends BaseConstraint<Structure.Declaration> {
 			}
 		}
 
-		if (!this.index && this.undeclared !== "reject") return true
-
-		const keys: Key[] = Object.keys(data)
-		keys.push(...Object.getOwnPropertySymbols(data))
-
-		for (let i = 0; i < keys.length; i++) {
-			const k = keys[i]
-
-			if (this.index) {
-				for (const node of this.index) {
-					if (node.signature.traverseAllows(k, ctx)) {
-						if (traversalKind === "Allows") {
-							const result = traverseKey(
-								k,
-								() => node.value.traverseAllows(data[k as never], ctx),
-								ctx
-							)
-							if (!result) return false
-						} else {
-							traverseKey(
-								k,
-								() => node.value.traverseApply(data[k as never], ctx),
-								ctx
-							)
-							if (ctx.failFast && ctx.currentErrorCount > errorCount)
-								return false
+		if (this.index || this.undeclared === "reject") {
+			const keys: Key[] = Object.keys(data)
+			keys.push(...Object.getOwnPropertySymbols(data))
+
+			for (let i = 0; i < keys.length; i++) {
+				const k = keys[i]
+
+				if (this.index) {
+					for (const node of this.index) {
+						if (node.signature.traverseAllows(k, ctx)) {
+							if (traversalKind === "Allows") {
+								const result = traverseKey(
+									k,
+									() => node.value.traverseAllows(data[k as never], ctx),
+									ctx
+								)
+								if (!result) return false
+							} else {
+								traverseKey(
+									k,
+									() => node.value.traverseApply(data[k as never], ctx),
+									ctx
+								)
+								if (ctx.failFast && ctx.currentErrorCount > errorCount)
+									return false
+							}
 						}
 					}
 				}
-			}
 
-			if (this.undeclared === "reject" && !this.declaresKey(k)) {
-				if (traversalKind === "Allows") return false
+				if (this.undeclared === "reject" && !this.declaresKey(k)) {
+					if (traversalKind === "Allows") return false
 
-				ctx.errorFromNodeContext({
-					// TODO: this should have its own error code
-					code: "predicate",
-					expected: "removed",
-					actual: "",
-					relativePath: [k],
-					meta: this.meta
-				})
+					ctx.errorFromNodeContext({
+						// TODO: this should have its own error code
+						code: "predicate",
+						expected: "removed",
+						actual: "",
+						relativePath: [k],
+						meta: this.meta
+					})
 
-				if (ctx.failFast) return false
+					if (ctx.failFast) return false
+				}
 			}
 		}
 

ark/type/CHANGELOG.md

@@ -1,5 +1,9 @@
 # arktype
 
+## 2.1.3
+
+Fix a jitless-mode bug causing default + `onUndeclaredKey` transformations to not apply (#1335)
+
 ## 2.1.2
 
 Allow non-zero-prefixed decimals in string.numeric ([#1333](https://github.com/arktypeio/arktype/pull/1333))

ark/type/__tests__/defaults.test.ts

@@ -58,6 +58,21 @@ contextualize(() => {
 			)
 		})
 
+		// https://github.com/arktypeio/arktype/issues/1335
+		it("jitless", () => {
+			const types = type.module(
+				{
+					foo: {
+						test: "string = 'test'"
+					}
+				},
+				{ jitless: true }
+			)
+
+			attest(types.foo({})).equals({ test: "test" })
+			attest(types.foo({ test: "provided" })).equals({ test: "provided" })
+		})
+
 		it("unions are defaultable", () => {
 			const o = type({
 				boo: "boolean = false"

ark/type/package.json

@@ -1,7 +1,7 @@
 {
 	"name": "arktype",
 	"description": "Optimized runtime validation for TypeScript syntax",
-	"version": "2.1.2",
+	"version": "2.1.3",
 	"license": "MIT",
 	"repository": {
 		"type": "git",

ark/util/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@ark/util",
-	"version": "0.43.2",
+	"version": "0.43.3",
 	"license": "MIT",
 	"author": {
 		"name": "David Blass",

ark/util/registry.ts

@@ -8,7 +8,7 @@ import { FileConstructor, objectKindOf } from "./objectKinds.ts"
 // recent node versions (https://nodejs.org/api/esm.html#json-modules).
 
 // For now, we assert this matches the package.json version via a unit test.
-export const arkUtilVersion = "0.43.2"
+export const arkUtilVersion = "0.43.3"
 
 export const initialRegistryContents = {
 	version: arkUtilVersion,