lint: fix openapi Clippy offenses

Author: augustoccesar

openapi/src/codegen.rs

@@ -46,7 +46,7 @@ impl CodeGen {
         // Write the current API version
         let version_file_content = format!(
             "pub const VERSION: crate::ApiVersion = crate::ApiVersion::V{};",
-            self.spec.version().replace('-', "_").replace('.', "_")
+            self.spec.version().replace(['-', '.'], "_")
         );
         write_to_file(version_file_content, base_path.join("version.rs"))?;
         let _ = writeln!(mod_rs_contents, "pub mod version;");

openapi/src/components.rs

@@ -355,7 +355,7 @@ struct DependencyCollector<'a> {
     deps: IndexSet<&'a ComponentPath>,
 }
 
-impl<'a> DependencyCollector<'a> {
+impl DependencyCollector<'_> {
     fn new() -> Self {
         Self::default()
     }

openapi/src/printable.rs

@@ -36,7 +36,7 @@ pub enum PrintableContainer {
     Map { key: MapKey, value: Box<PrintableType>, is_ref: bool },
 }
 
-impl<'a> Display for PrintableWithLifetime<'a> {
+impl Display for PrintableWithLifetime<'_> {
     fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
         let Some(lifetime) = self.lifetime else {
             if self.impl_into {
@@ -262,7 +262,7 @@ impl<'a> PathWithIdent<'a> {
     }
 }
 
-impl<'a> Display for PathWithIdent<'a> {
+impl Display for PathWithIdent<'_> {
     fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
         if let Some(path) = self.path {
             write!(f, "{}::", path.krate.lib_name())?;

openapi/src/templates/enums.rs

@@ -8,7 +8,7 @@ use crate::templates::miniserde::gen_enum_of_objects_miniserde;
 use crate::templates::object_writer::{write_derives_line, ObjectWriter};
 use crate::templates::utils::{SerdeDeriveState, ShouldDerive};
 
-impl<'a> ObjectWriter<'a> {
+impl ObjectWriter<'_> {
     /// Fallback case if no more specific structure inferred
     pub fn write_arbitrary_enum_variants(&self, out: &mut String, variants: &[EnumVariant]) {
         if !self.usage.used_as_request_param {
@@ -169,7 +169,7 @@ impl<'a> ObjectWriter<'a> {
                     }}
                 }}
             }}
-            
+
             impl std::str::FromStr for {enum_name} {{
                 type Err = {from_str_err};
                 fn from_str(s: &str) -> Result<Self, Self::Err> {{
@@ -184,7 +184,7 @@ impl<'a> ObjectWriter<'a> {
                     f.write_str(self.as_str())
                 }}
             }}
-            
+
             impl std::fmt::Debug for {enum_name} {{
                 fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {{
                     f.write_str(self.as_str())

openapi/src/templates/miniserde.rs

@@ -150,7 +150,7 @@ fn build_inner(ident: &RustIdent, builder_name: &RustIdent, objects: &EnumOfObje
     out
 }
 
-impl<'a> ObjectWriter<'a> {
+impl ObjectWriter<'_> {
     pub fn gen_miniserde_struct_deserialize(&self, out: &mut String, fields: &[StructField]) {
         let ident = self.ident;
         let builder_name = RustIdent::joined(ident, "Builder");

openapi/src/templates/structs.rs

@@ -11,7 +11,7 @@ use crate::templates::utils::{
 };
 use crate::templates::ObjectWriter;
 
-impl<'a> ObjectWriter<'a> {
+impl ObjectWriter<'_> {
     pub fn write_struct_definition(&self, out: &mut String, struct_: &Struct) {
         let mut serde_derive = SerdeDeriveState::default();
         // In theory this could be supported, but it would require not borrowing in request structs
@@ -127,7 +127,7 @@ impl<'a> ObjectWriter<'a> {
             }
         }
         if let Some(renamer) = field.rename_name() {
-            serde_derive.maybe_write_rename(out, &renamer);
+            serde_derive.maybe_write_rename(out, renamer);
         }
 
         if !field.required && field.rust_type.is_option() && self.usage.used_as_request_param {
@@ -136,7 +136,7 @@ impl<'a> ObjectWriter<'a> {
 
         if matches!(
             field.rust_type.with_option_stripped(),
-            RustType::Simple(SimpleType::Ext(ExtType::Value { .. }))
+            RustType::Simple(SimpleType::Ext(ExtType::Value))
         ) {
             let with =
                 if field.rust_type.is_option() { "with_serde_json_opt" } else { "with_serde_json" };