Merge pull request #772 from arlyon/arlyon/large-stack-frames

arlyon · web-flow · commit abc5d2d98516 · 2025-10-30T19:46:13.000Z
diff --git a/async-stripe-webhook/src/generated/mod.rs b/async-stripe-webhook/src/generated/mod.rs
diff --git a/async-stripe-webhook/src/lib.rs b/async-stripe-webhook/src/lib.rs
@@ -1,3 +1,4 @@
+#![deny(clippy::large_stack_frames)]
 #![allow(clippy::large_enum_variant)]
 #![recursion_limit = "256"]
 //! This crate provides Rust bindings for handling [Stripe webhook events](https://stripe.com/docs/webhooks).
diff --git a/generated/async-stripe-billing/src/mod.rs b/generated/async-stripe-billing/src/mod.rs
@@ -1,4 +1,5 @@
 #![recursion_limit = "256"]
+#![deny(clippy::large_stack_frames)]
 #![allow(clippy::large_enum_variant)]
 #![allow(rustdoc::broken_intra_doc_links)]
 #![allow(rustdoc::invalid_html_tags)]
diff --git a/generated/async-stripe-checkout/src/mod.rs b/generated/async-stripe-checkout/src/mod.rs
@@ -1,4 +1,5 @@
 #![recursion_limit = "256"]
+#![deny(clippy::large_stack_frames)]
 #![allow(clippy::large_enum_variant)]
 #![allow(rustdoc::broken_intra_doc_links)]
 #![allow(rustdoc::invalid_html_tags)]
diff --git a/generated/async-stripe-connect/src/mod.rs b/generated/async-stripe-connect/src/mod.rs
@@ -1,4 +1,5 @@
 #![recursion_limit = "256"]
+#![deny(clippy::large_stack_frames)]
 #![allow(clippy::large_enum_variant)]
 #![allow(rustdoc::broken_intra_doc_links)]
 #![allow(rustdoc::invalid_html_tags)]
diff --git a/generated/async-stripe-core/src/mod.rs b/generated/async-stripe-core/src/mod.rs
@@ -1,4 +1,5 @@
 #![recursion_limit = "256"]
+#![deny(clippy::large_stack_frames)]
 #![allow(clippy::large_enum_variant)]
 #![allow(rustdoc::broken_intra_doc_links)]
 #![allow(rustdoc::invalid_html_tags)]
diff --git a/generated/async-stripe-fraud/src/mod.rs b/generated/async-stripe-fraud/src/mod.rs
@@ -1,4 +1,5 @@
 #![recursion_limit = "256"]
+#![deny(clippy::large_stack_frames)]
 #![allow(clippy::large_enum_variant)]
 #![allow(rustdoc::broken_intra_doc_links)]
 #![allow(rustdoc::invalid_html_tags)]
diff --git a/generated/async-stripe-issuing/src/mod.rs b/generated/async-stripe-issuing/src/mod.rs
@@ -1,4 +1,5 @@
 #![recursion_limit = "256"]
+#![deny(clippy::large_stack_frames)]
 #![allow(clippy::large_enum_variant)]
 #![allow(rustdoc::broken_intra_doc_links)]
 #![allow(rustdoc::invalid_html_tags)]
diff --git a/generated/async-stripe-misc/src/mod.rs b/generated/async-stripe-misc/src/mod.rs
@@ -1,4 +1,5 @@
 #![recursion_limit = "256"]
+#![deny(clippy::large_stack_frames)]
 #![allow(clippy::large_enum_variant)]
 #![allow(rustdoc::broken_intra_doc_links)]
 #![allow(rustdoc::invalid_html_tags)]
diff --git a/generated/async-stripe-payment/src/mod.rs b/generated/async-stripe-payment/src/mod.rs
@@ -1,4 +1,5 @@
 #![recursion_limit = "256"]
+#![deny(clippy::large_stack_frames)]
 #![allow(clippy::large_enum_variant)]
 #![allow(rustdoc::broken_intra_doc_links)]
 #![allow(rustdoc::invalid_html_tags)]
diff --git a/generated/async-stripe-product/src/mod.rs b/generated/async-stripe-product/src/mod.rs
@@ -1,4 +1,5 @@
 #![recursion_limit = "256"]
+#![deny(clippy::large_stack_frames)]
 #![allow(clippy::large_enum_variant)]
 #![allow(rustdoc::broken_intra_doc_links)]
 #![allow(rustdoc::invalid_html_tags)]
diff --git a/generated/async-stripe-shared/src/mod.rs b/generated/async-stripe-shared/src/mod.rs
@@ -1,4 +1,5 @@
 #![recursion_limit = "256"]
+#![deny(clippy::large_stack_frames)]
 #![allow(clippy::large_enum_variant)]
 #![allow(rustdoc::broken_intra_doc_links)]
 #![allow(rustdoc::invalid_html_tags)]
diff --git a/generated/async-stripe-terminal/src/mod.rs b/generated/async-stripe-terminal/src/mod.rs
@@ -1,4 +1,5 @@
 #![recursion_limit = "256"]
+#![deny(clippy::large_stack_frames)]
 #![allow(clippy::large_enum_variant)]
 #![allow(rustdoc::broken_intra_doc_links)]
 #![allow(rustdoc::invalid_html_tags)]
diff --git a/generated/async-stripe-treasury/src/mod.rs b/generated/async-stripe-treasury/src/mod.rs
@@ -1,4 +1,5 @@
 #![recursion_limit = "256"]
+#![deny(clippy::large_stack_frames)]
 #![allow(clippy::large_enum_variant)]
 #![allow(rustdoc::broken_intra_doc_links)]
 #![allow(rustdoc::invalid_html_tags)]
diff --git a/openapi/src/codegen.rs b/openapi/src/codegen.rs
@@ -111,6 +111,7 @@ impl CodeGen {
             let mod_rs = formatdoc! {
                 r#"
             #![recursion_limit = "256"]
+            #![deny(clippy::large_stack_frames)]
             #![allow(clippy::large_enum_variant)]
             #![allow(rustdoc::broken_intra_doc_links)]
             #![allow(rustdoc::invalid_html_tags)]
diff --git a/openapi/src/main.rs b/openapi/src/main.rs
@@ -104,6 +104,10 @@ fn main() -> Result<()> {
 
     if !args.dry_run {
         info!("Formatting generated files");
+
+        // in a rather bizarre turn of events, we actually need to run fmt _twice_
+        // to get it 'settled'. otherwise it will fail formatting checks
+        let _out = fmt_cmd.output()?;
         let out = fmt_cmd.output()?;
         if !out.status.success() {
             bail!("Rustfmt failed with outputs {out:?}");
diff --git a/openapi/src/webhook.rs b/openapi/src/webhook.rs
@@ -74,7 +74,7 @@ fn write_event_object(components: &Components, out_path: &Path) -> anyhow::Resul
         let evt_type = &webhook_obj.event_type;
         let _ = writeln!(
             match_inner,
-            r#""{evt_type}" => Self::{ident}(FromValueOpt::from_value(data)?),"#
+            r#"if typ == "{evt_type}" {{ return FromValueOpt::from_value(data).map(Self::{ident}) }}"#
         );
     }
     let _ = writedoc! {enum_body, r#"
@@ -93,17 +93,16 @@ fn write_event_object(components: &Components, out_path: &Path) -> anyhow::Resul
     /// The event data for a webhook event.
     pub enum EventObject {{
         {enum_body}
-    }} 
+    }}
     "#};
 
     let _ = writedoc! {out, r#"
     impl EventObject {{
         pub(crate) fn from_raw_data(typ: &str, data: miniserde::json::Value) -> Option<Self> {{
             use stripe_types::miniserde_helpers::FromValueOpt;
-            Some(match typ {{
-                {match_inner}
-                _ => Self::Unknown(data),
-            }})
+            {match_inner}
+
+            Some(Self::Unknown(data))
         }}
     }}
     "#};

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+#![deny(clippy::large_stack_frames)]`
`1`	`2`	`#![allow(clippy::large_enum_variant)]`
`2`	`3`	`#![recursion_limit = "256"]`
`3`	`4`	`//! This crate provides Rust bindings for handling [Stripe webhook events](https://stripe.com/docs/webhooks).`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`#![recursion_limit = "256"]`
	`2`	`+#![deny(clippy::large_stack_frames)]`
`2`	`3`	`#![allow(clippy::large_enum_variant)]`
`3`	`4`	`#![allow(rustdoc::broken_intra_doc_links)]`
`4`	`5`	`#![allow(rustdoc::invalid_html_tags)]`