Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency breaks CI #532

Closed
ferrohd opened this issue Apr 8, 2024 · 1 comment · Fixed by #534
Closed

Dependency breaks CI #532

ferrohd opened this issue Apr 8, 2024 · 1 comment · Fixed by #534
Labels
bug Something isn't working

Comments

@ferrohd
Copy link
Contributor

ferrohd commented Apr 8, 2024 •
edited
Loading

Describe the bug

The MSRV in CI is pinned to 1.68.0 but the dependency lalrpop requires at least 1.70.0 to build, failing the test matrix and blocking new PR like #518 #527 #524.

To Reproduce

Trigger the CI by pushing to master or open a new PR.

Expected behavior

A not failing CI

Code snippets

No response

OS

linux

Rust version

1.68.0

Library version

latest

API version

latest

Additional context

Solution 1

Bump the MSRV in CI to 1.70.0. This doesn't break the 3-versions-behind-latest rule, being stable at 1.77.0

Solution 2

Pin the lalrpop dependency to 0.20.0 which is the latest with MSRV <= 1.68.0
@ferrohd ferrohd added the bug Something isn't working label Apr 8, 2024
@ferrohd ferrohd changed the title Dependency break CI Dependency breaks CI Apr 8, 2024
arlyon added a commit that referenced this issue Apr 9, 2024
@arlyon
bump msrv (closes #532)
9390ec5
arlyon added a commit that referenced this issue Apr 9, 2024
@arlyon
fix: bump msrv (closes #532)
afbd72c
arlyon added a commit that referenced this issue Apr 9, 2024
@arlyon
fix: bump msrv (closes #532)
a798fdc
arlyon added a commit that referenced this issue Apr 9, 2024
@arlyon
fix: bump MSRV (closes #532)
1379a90
@arlyon arlyon mentioned this issue Apr 9, 2024
Merged
2 tasks
@arlyon
Copy link
Owner

arlyon commented Apr 9, 2024

Thanks for the report. Got a PR that I will sort out tonight

jwiesler added a commit that referenced this issue Apr 26, 2024
@jwiesler
Merge pull request #534 from arlyon/arlyon/bump-msrv
65ef902 
bump msrv (closes #532)
arlyon pushed a commit that referenced this issue Apr 26, 2024
@semantic-release-bot
chore(release): 0.35.1 [skip ci]
15b40bc 
## [0.35.1](v0.35.0...v0.35.1) (2024-04-26)

### Bug Fixes

* bump MSRV (closes [#532](#532)) ([1379a90](1379a90))
* Unused import ([baf0b98](baf0b98))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bump msrv (closes #532) arlyon/async-stripe
2 participants
@arlyon @ferrohd