Make calculation of idealised share metrics only log warning on error (#4568)

Instead of erroring out the scheduling algo when the idealised share
metrics fail to calculate, now we just log a warning

The idealised share code only calculates some non-critical metrics, so
we shouldn't stop scheduling just because they aren't being calculated

Signed-off-by: JamesMurkin <[email protected]>

Author: JamesMurkin

internal/scheduler/scheduling/scheduling_algo.go

@@ -565,7 +565,7 @@ func (l *FairSchedulingAlgo) SchedulePool(
 	if err != nil {
 		return nil, nil, err
 	}
-	err = CalculateIdealisedValue(
+	idealisedShareErr := CalculateIdealisedValue(
 		ctx,
 		fsctx.schedulingContext,
 		nodes,
@@ -576,8 +576,8 @@ func (l *FairSchedulingAlgo) SchedulePool(
 		l.resourceListFactory,
 		resourceUnit,
 	)
-	if err != nil {
-		return nil, nil, err
+	if idealisedShareErr != nil {
+		log.Warnf("failed to calculated idealised share for pool %s - %s", fsctx.pool, idealisedShareErr)
 	}
 
 	scheduler := NewPreemptingQueueScheduler(