rabbit food - fix hook_points_counter calculation

Author: tabrisnet

lib/functions/general/extensions.sh

@@ -232,7 +232,17 @@ function initialize_extension_manager() {
 		hook_point_functions=""
 		declare hook_point_function_sortname
 		for hook_point_function_sortname in ${hook_point_functions_sorted_by_sort_id}; do
-			hook_point_functions="${hook_point_functions} ${hook_point_functions_sortname_to_realname[${hook_point_function_sortname}]}"
+			realname="${hook_point_functions_sortname_to_realname[${hook_point_function_sortname}]}"
+			if [[ -v extension_optout && ${#extension_optout[@]} -ne 0 ]]; then
+			# most common case this array is empty/non-existent, so bail out soonest
+				for func in "${extension_optout[@]}"; do
+					if [[ "$func" == "${hook_point}__${realname}" ]]; then
+						continue 2
+					fi
+				done
+			fi
+
+			hook_point_functions="${hook_point_functions} ${realname}"
 		done
 		# shellcheck disable=SC2086
 		hook_point_functions="$(echo -n ${hook_point_functions})"
@@ -276,18 +286,6 @@ function initialize_extension_manager() {
 		declare -a list_of_called_functions=()
 
 		for hook_point_function in ${hook_point_functions}; do
-			opt_out=false
-			if [[ -v extension_optout && ${#extension_optout[@]} -ne 0 ]]; then
-			# most common case this array is empty/non-existent, so bail out soonest
-				for func in "${extension_optout[@]}"; do
-					if [[ "$func" == "${hook_point}__${hook_point_function}" ]]; then
-						opt_out=true
-					fi
-				done
-			fi
-			if $opt_out; then
-				continue; #skip processing this function
-			fi
 			hook_point_functions_loop_counter=$((hook_point_functions_loop_counter + 1))
 
 			# store the full name in a hash, so we can track which were actually called later.