Skip to content

extensions: radxa-aic8800: allow 6.17; skip DKMS only on >= 6.18 #8731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2025
Merged

extensions: radxa-aic8800: allow 6.17; skip DKMS only on >= 6.18 #8731

merged 1 commit into from
Oct 8, 2025

Conversation

@HackingGate
Copy link
Contributor

@HackingGate HackingGate commented Oct 8, 2025 •
edited
Loading

The upstream driver in radxa-pkg/aic8800 builds successfully against Linux 6.17. Relax the version guard so we only skip installing the aic8800 DKMS package on kernels >= 6.18.

Relax radxa-aic8800's build restriction (skip >= 6.17 to skip >= 6.18) to allow it to be built on 6.17.
As raxda-pkg/aic8800 have fixed its build for linux 6.17.

Fix: #8732

How Has This Been Tested?

ENABLE_EXTENSIONS="radxa-aic8800"
AIC8800_TYPE="usb"

Checklist:

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@HackingGate
extensions: radxa-aic8800: allow 6.17; skip DKMS only on >= 6.18
e9ef6fc 
The upstream driver in radxa-pkg/aic8800 builds successfully against Linux 6.17. Relax the version guard so we only skip installing the aic8800 DKMS package on kernels >= 6.18.
@github-actions github-actions bot added size/small PR with less then 50 lines 11 Milestone: Fourth quarter release Needs review Seeking for review Framework Framework components labels Oct 8, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 8, 2025 •
edited
Loading

Walkthrough

Updates extensions/radxa-aic8800.sh by changing a kernel version gate in post_install_kernel_debs__install_aic8800_dkms_package from ">= 6.17" to ">= 6.18", altering the early-return condition that skips aic8800 DKMS installation for kernels at or above 6.18. No other logic is modified.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

Hardware, Build, Patches

Suggested reviewers

  • igorpecovnik
  • EvilOlaf
  • pyavitz
  • prahal
  • krachlatte

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title succinctly captures the core change by indicating that the radxa-aic8800 extension now permits kernel 6.17 builds and only skips DKMS installation for kernels 6.18 and above, making it specific and directly tied to the changeset without extraneous detail.
Description Check ✅ Passed The pull request description clearly explains the change to relax the kernel version guard for the radxa-aic8800 DKMS package to include Linux 6.17, references the upstream fix, and details testing steps, demonstrating its direct relevance to the actual code modifications.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions bot added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Oct 8, 2025
@igorpecovnik igorpecovnik merged commit 33f04bc into armbian:main Oct 8, 2025
1 check passed
@coderabbitai coderabbitai bot mentioned this pull request Oct 22, 2025
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EvilOlaf EvilOlaf EvilOlaf approved these changes

@igorpecovnik igorpecovnik Awaiting requested review from igorpecovnik igorpecovnik is a code owner

@krachlatte krachlatte Awaiting requested review from krachlatte

@prahal prahal Awaiting requested review from prahal

@pyavitz pyavitz Awaiting requested review from pyavitz

Assignees

No one assigned

Labels

11 Milestone: Fourth quarter release Framework Framework components Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: aic8800 driver will not get installed on rockchip64-edge

3 participants

@HackingGate @EvilOlaf @igorpecovnik