Add post-build Armbian extension for burnable JetHub boards #8844
Conversation
Signed-off-by: Nikita Maslo <[email protected]>
github-actions
bot
added
size/medium
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| DEFAULT_CONSOLE="serial" | ||
| HAS_VIDEO_OUTPUT="no" | ||
| MODULES_BLACKLIST="rtw88_8822cs" | ||
| enable_extension "jethub-burn" |
| FULL_DESKTOP="yes" | ||
| SERIALCON="ttyAML0" | ||
| #BOOT_LOGO="desktop" | ||
| enable_extension "jethub-burn" |
| DEFAULT_CONSOLE="serial" | ||
| HAS_VIDEO_OUTPUT="no" | ||
| MODULES_BLACKLIST="rtw88_8822cs" | ||
| enable_extension "jethub-burn" |
| @@ -0,0 +1,117 @@ | |||
| #!/usr/bin/env bash | |||
| # Extension: jethub-burn | |||
There was a problem hiding this comment.
insert JetHome copyright
#
# SPDX-License-Identifier: GPL-2.0
# Copyright (c) 2025 JetHome
# This file is a part of the Armbian Build Framework https://github.com/armbian/build/
#
| fetch_from_repo "${repo_url}" "${name}" "${ref}" | ||
|
|
||
| local packer_path | ||
| packer_path="$(find "${base}" -maxdepth 12 -type f -path '*/tools/aml_image_v2_packer_new' -print -quit)" |
There was a problem hiding this comment.
you cat set tool path to ${SRC}/cache/sources/jethome-tools/tools/aml_image_v2_packer_new, so do not use find
| packer_path="$(find "${base}" -maxdepth 12 -type f -path '*/tools/aml_image_v2_packer_new' -print -quit)" | ||
| [[ -n "${packer_path}" ]] || exit_with_error "aml_image_v2_packer_new not found under ${base}" | ||
|
|
||
| declare -g TOOLS_DIR="$(dirname "$(dirname "${packer_path}")")" |
There was a problem hiding this comment.
and there use ${SRC}/cache/sources/ as base path for fethed artifacts
|
|
||
| display_alert "make_burn" "Extracting partitions (losetup -P)..." "info" | ||
| local loopdev | ||
| loopdev="$(losetup --find --show -P "$input_img")" || exit_with_error "losetup failed for $input_img" |
There was a problem hiding this comment.
find base partition file, do not re-extract builded image
or
use gdisk/dd magic for copy partition without use loop device.
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new extension jethub-burn that automatically converts Armbian .img files into Amlogic burn image format after building, specifically for JetHub boards (j80, j100, j200).
Key changes:
- New extension script implementing Amlogic burn image conversion tooling
- Enables the extension for three JetHub board configurations
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| extensions/jethub-burn.sh | Implements bootstrap tools fetching, DTB building, partition extraction, and burn image packing logic |
| config/boards/jethubj80.conf | Enables jethub-burn extension for JetHub J80 board |
| config/boards/jethubj100.conf | Enables jethub-burn extension for JetHub J100 board |
| config/boards/jethubj200.conf | Enables jethub-burn extension for JetHub J200 board |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| local loopdev | ||
| loopdev="$(losetup --find --show -P "$input_img")" || exit_with_error "losetup failed for $input_img" | ||
| trap 'losetup -d "$loopdev" 2>/dev/null || true; rm -rf "$tmpdir"' RETURN |
There was a problem hiding this comment.
The trap command on line 61 overrides the existing trap on line 39, which means the tmpdir cleanup from line 39 won't execute if the losetup succeeds. This could lead to tmpdir not being cleaned up properly. The trap should combine both cleanup actions instead of replacing the first one.
| jethubj80) dts_name="meson-gxl-s905w-jethome-jethub-j80.dts"; bins_subdir="j80" ;; | ||
| jethubj100) dts_name="meson-axg-jethome-jethub-j100.dts"; bins_subdir="j100" ;; | ||
| jethubj200) dts_name="meson-sm1-jethome-jethub-j200.dts"; bins_subdir="j200" ;; | ||
| *) exit_with_error "Unsupported board: ${BOARD} (supported: j80, j100, j200)";; | ||
| esac | ||
|
|
There was a problem hiding this comment.
[nitpick] The board-to-configuration mapping is hardcoded with duplicate information. The bins_subdir could be derived from the board name (e.g., 'jethubj80' → 'j80') to reduce duplication. Only the dts_name needs to be board-specific.
| jethubj80) dts_name="meson-gxl-s905w-jethome-jethub-j80.dts"; bins_subdir="j80" ;; | |
| jethubj100) dts_name="meson-axg-jethome-jethub-j100.dts"; bins_subdir="j100" ;; | |
| jethubj200) dts_name="meson-sm1-jethome-jethub-j200.dts"; bins_subdir="j200" ;; | |
| *) exit_with_error "Unsupported board: ${BOARD} (supported: j80, j100, j200)";; | |
| esac | |
| jethubj80) dts_name="meson-gxl-s905w-jethome-jethub-j80.dts"; ;; | |
| jethubj100) dts_name="meson-axg-jethome-jethub-j100.dts"; ;; | |
| jethubj200) dts_name="meson-sm1-jethome-jethub-j200.dts"; ;; | |
| *) exit_with_error "Unsupported board: ${BOARD} (supported: j80, j100, j200)";; | |
| esac | |
| bins_subdir="${BOARD#jethub}" # Extract substring after 'jethub' |
|
Also: please don't use |
4 participants
Description
Add post-build Armbian extension for burnable JetHub boards (for j80, j100 and j200)
How Has This Been Tested?
Builds and flashes ok