Prevent guessing of slug encoding [ART-81]

[zachgarwood]

The short description is that getUft8Slug() was guessing the wrong encoding and erroneously transcoding the given string.

For the long description, see this Twill PR: area17/twill#2771.

[github-actions]

Automated PR Summary

The PR modifies the getUtf8Slug function within StringHelpers.php. It adjusts the handling of character encoding conversion by allowing an optional 'from_encoding' parameter to be specified in the options array. If 'from_encoding' is not provided, it defaults to converting based on all supported encodings, similar to the original behavior.

Potential Bugs

1. Default 'from_encoding' behavior ambiguity: The original implementation passed all available encodings to mb_convert_encoding by default. The new implementation defaults to null if 'from_encoding' is not specified, which could potentially change the behavior if mb_convert_encoding interprets null differently than an explicit list of encodings.
2. Handling of unsupported encodings: Since 'from_encoding' is now configurable, there's a risk that an unsupported encoding could be passed, leading to runtime errors if not properly handled or validated.
3. Inconsistent application of conversion: The refactored code applies the conversion inside the condition that checks if 'from_encoding' is set in options. If 'from_encoding' is mistakenly omitted or set to null, the string conversion might not occur as intended, which could lead to issues with strings that require specific encoding treatments.

[deepsource-io]

Here's the code health analysis summary for commits 438da10..19c3e06. View details on DeepSource ↗.

Analysis Summary

Analyzer	Status	Summary	Link
PHP	❌ Failure	❗ 18 occurences introduced	View Check ↗
JavaScript	✅ Success		View Check ↗

---

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[nikhiltri]

Looks good! ⭐