Skip to content

XmlWriterWrap should be abstract and have final methods #128

@victornoel

Description

@victornoel

I see XmlWriterWrap was introduced in #109.

I believe that envelopes should be abstract and have all their methods be final : that would allow for removing the DesignForExtensionCheck suppression from checkstyle. It exists for good reasons, it is dangerous to use inheritance, but it is way safer when one can't override inherited behaviour.

Also it should be abstract because as a good rule, classes should be either final or abstract to avoid confusing situation with inheritance.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions