Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extraVolumes and extraVolumeMounts #147

Open
PG2000 opened this issue Jul 1, 2024 · 5 comments
Open

extraVolumes and extraVolumeMounts #147

PG2000 opened this issue Jul 1, 2024 · 5 comments

Comments

@PG2000
Copy link
Contributor

PG2000 commented Jul 1, 2024

Hello,

many charts allow to provide extraVolumes and extraVolumeMounts in order to mount volumes (certificates, configmaps etc.) that should be used by the controller.

It would be great if helmify would support this.

Maybe via some flags.

If ok for you then i could implement this.

@arttor
Copy link
Owner

arttor commented Jul 1, 2024

@PG2000 good suggestion, but as i can see this approach also goes with extraArgs, extraEnvVars, extraEnvVarsCM, extraEnvVarsSecret. Is it makes sense to add all of these? If so, which feature flags should we use?

  • extraVolumes for extraVolumes and extraVolumeMounts
  • extraArgs for extraArgs
  • extraEnv for extraEnvVars and extraEnvVarsCM and extraEnvVarsSecret

or just one extra flag for all?

@PG2000
Copy link
Contributor Author

PG2000 commented Jul 1, 2024

@arttor for me the latter would be fine.

@arttor
Copy link
Owner

arttor commented Jul 1, 2024

ok, go ahead!

@PG2000
Copy link
Contributor Author

PG2000 commented Jul 10, 2024

@arttor any hints how to implement this?

I've seen that i haven't a hook in order to add some template code.

So. i had the following ideas:

  1. Render a marker like:
#@ begin
#@   {{ helm template code ...}}
#@ end

and replace it after marshaling the struct.

What do you think?

@arttor
Copy link
Owner

arttor commented Jul 15, 2024

sorry, i didn't got the question. But probably you a looking some thing like this
https://github.com/arttor/helmify/blob/main/examples/app/templates/deployment.yaml#L53C24-L53C30

resources: {{- toYaml .Values.myapp.app.resources | nindent 10 }}

It takes object or array from values file and adds it to template with correct indentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants