You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some of the classes / models do not contain type declarations.
Specifically model scopes and relationships are currently lacking argument and return types.
IMHO adding them would help to avoid breaking compatibility between updates and user land extensions.
Is there any reason the exposed methods (and otherwise) are currently open?
Is this a planned change?
Proposal
Maintain common DocBlocks, argument and return type hints on Laravel models as well as other classes.
Summary
Some of the classes / models do not contain type declarations.
Specifically model scopes and relationships are currently lacking argument and return types.
IMHO adding them would help to avoid breaking compatibility between updates and user land extensions.
Is there any reason the exposed methods (and otherwise) are currently open?
Is this a planned change?
Proposal
Maintain common DocBlocks, argument and return type hints on Laravel models as well as other classes.
Additional Notes
https://github.com/asantibanez/laravel-eloquent-state-machines/blob/master/src/Models/StateHistory.php
https://github.com/asantibanez/laravel-eloquent-state-machines/blob/master/src/Models/PendingTransition.php
[...]
The text was updated successfully, but these errors were encountered: