-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate stylesheets #14
Comments
I also think that the CodeRay and Font Awesome stylesheets should be loaded after the Asciidoctor stylesheet (in that order). |
Should we not include the foundation javascript as well? |
The Foundation JavaScript is only necessary for using one of the Foundation components. These are indicated with the "JS" label in the Foundation docs. (see http://foundation.zurb.com/sites/docs/) These aren't needed for the AsciiDoc content, but could be useful for other components on the screen. |
Looking at this issue and trying to remove the css... could you @mojavelinux create a stylesheet that would include both asciidoctor and foundation in a PR? |
We can't do that until asciidoctor/asciidoctor-stylesheet-factory#18 is resolved (because that's the solution). We should probably have a flag on that build that includes the whole Foundation stylesheet or just part of it so that you can either use Foundation minimally or a complete integration. I'll note that. |
Cool, I'll keep my eye on your progress 👍 |
Of course, we also need to upgrade to Foundation 6. Lots of progress ahead! |
👍 for Foundation 6 |
Any movement on all of this @mojavelinux? |
Yes, I'm starting to work with @Mogztter on the upgrade to Foundation 5, then Foundation 6, then get the build working to create a stylesheet for embeddable documents. See asciidoctor/asciidoctor.org#564. |
The default page layout should not be loading both the default Asciidoctor stylesheet (asciidoctor.css) and Foundation (foundation.css). The default Asciidoctor stylesheet already includes Foundation (and Normalizer), so this combination includes a tremendous number of redundant (and potentially conflicting) styles.
What needs to be done is to create a combined stylesheet that includes Foundation and just the parts of the Asciidoctor stylesheet that supplement Foundation. This is essentially the use case that asciidoctor/asciidoctor-stylesheet-factory#18 is proposing to address.
The other approach is to simply start writing a new stylesheet for AsciiDoc components that includes only what is needed to style them within a Jekyll site. Admittedly, this is more time consuming, but will likely produce the most concise result in the end.
The text was updated successfully, but these errors were encountered: