generator: Mark QNX c_void types as opaque to get raw pointers

Long ago in #339 I added "opaque" types to ensure that pointers to it
stay as pointers in FFI rather than get converted to `&mut` borrows
which don't carry the load of an arbitrary pointer value to "something
unknown" (= opaque).  When the QNX types were added in #429 and #760
some time later, they weren't added to this list and turned into borrows
making them impossible to be handled safely in user code.

Likewise in #433 I changed the "platform type" for `SECURITY_ATTRIBUTES`
(which is a POD) to `c_void` but the borrow in the builder remains.
With a `c_void` it's more useful to map these as a raw `*const` pointer
too.

Author: MarijnS95

Changelog.md

@@ -18,6 +18,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
+- `push_next()` has been renamed to `extend()` and marked as `unsafe`. Users are encouraged to call `push()` for singular structs instead. (#909)
+- Treat QNX "void" type aliases and `SECURITY_ATTRIBUTES` as "opaque" to make them raw pointers instead of borrows in public structures. (#950)
 - Enable passing mutable arrays of `pNext`-initialized structs for these remaining extension functions: (#966)
   - `VK_EXT_tooling_info`: `get_physical_device_tool_properties()`;
   - `VK_KHR_cooperative_matrix`: `get_physical_device_cooperative_matrix_properties()`;
@@ -26,7 +28,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
     - `get_pipeline_executable_properties()`;
     - `get_pipeline_executable_statistics()`.
   The expected length of this array can be queried with the respective `*_len()` variant of these functions.
-- `push_next()` has been renamed to `extend()` and marked as `unsafe`. Users are encouraged to call `push()` for singular structs instead. (#909)
 - Changed and renamed `RawPtr::as_raw_ptr(&self)` trait function to a by-value `RawPtr::to_raw_ptr(self)` function. (#965)
 - All `Extends{Root}` traits have been replaced with a single `Extends<Root>` trait using generics. (#971)
 - Moved `push()` and `extend()` methods from individual Vulkan structs (builders) into the `TaggedStructure` trait. (#994)

ash/src/vk/definitions.rs

@@ -8689,12 +8689,12 @@ impl<'a> ScreenSurfaceCreateInfoQNX<'a> {
         self
     }
     #[inline]
-    pub fn context(mut self, context: &'a mut _screen_context) -> Self {
+    pub fn context(mut self, context: *mut _screen_context) -> Self {
         self.context = context;
         self
     }
     #[inline]
-    pub fn window(mut self, window: &'a mut _screen_window) -> Self {
+    pub fn window(mut self, window: *mut _screen_window) -> Self {
         self.window = window;
         self
     }
@@ -9684,7 +9684,7 @@ unsafe impl<'a> TaggedStructure<'a> for ExportMemoryWin32HandleInfoNV<'a> {
 unsafe impl Extends<MemoryAllocateInfo<'_>> for ExportMemoryWin32HandleInfoNV<'_> {}
 impl<'a> ExportMemoryWin32HandleInfoNV<'a> {
     #[inline]
-    pub fn attributes(mut self, attributes: &'a SECURITY_ATTRIBUTES) -> Self {
+    pub fn attributes(mut self, attributes: *const SECURITY_ATTRIBUTES) -> Self {
         self.p_attributes = attributes;
         self
     }
@@ -11868,7 +11868,7 @@ unsafe impl<'a> TaggedStructure<'a> for ExportMemoryWin32HandleInfoKHR<'a> {
 unsafe impl Extends<MemoryAllocateInfo<'_>> for ExportMemoryWin32HandleInfoKHR<'_> {}
 impl<'a> ExportMemoryWin32HandleInfoKHR<'a> {
     #[inline]
-    pub fn attributes(mut self, attributes: &'a SECURITY_ATTRIBUTES) -> Self {
+    pub fn attributes(mut self, attributes: *const SECURITY_ATTRIBUTES) -> Self {
         self.p_attributes = attributes;
         self
     }
@@ -12487,7 +12487,7 @@ unsafe impl<'a> TaggedStructure<'a> for ExportSemaphoreWin32HandleInfoKHR<'a> {
 unsafe impl Extends<SemaphoreCreateInfo<'_>> for ExportSemaphoreWin32HandleInfoKHR<'_> {}
 impl<'a> ExportSemaphoreWin32HandleInfoKHR<'a> {
     #[inline]
-    pub fn attributes(mut self, attributes: &'a SECURITY_ATTRIBUTES) -> Self {
+    pub fn attributes(mut self, attributes: *const SECURITY_ATTRIBUTES) -> Self {
         self.p_attributes = attributes;
         self
     }
@@ -13006,7 +13006,7 @@ unsafe impl<'a> TaggedStructure<'a> for ExportFenceWin32HandleInfoKHR<'a> {
 unsafe impl Extends<FenceCreateInfo<'_>> for ExportFenceWin32HandleInfoKHR<'_> {}
 impl<'a> ExportFenceWin32HandleInfoKHR<'a> {
     #[inline]
-    pub fn attributes(mut self, attributes: &'a SECURITY_ATTRIBUTES) -> Self {
+    pub fn attributes(mut self, attributes: *const SECURITY_ATTRIBUTES) -> Self {
         self.p_attributes = attributes;
         self
     }
@@ -54989,7 +54989,7 @@ unsafe impl<'a> TaggedStructure<'a> for ImportScreenBufferInfoQNX<'a> {
 unsafe impl Extends<MemoryAllocateInfo<'_>> for ImportScreenBufferInfoQNX<'_> {}
 impl<'a> ImportScreenBufferInfoQNX<'a> {
     #[inline]
-    pub fn buffer(mut self, buffer: &'a mut _screen_buffer) -> Self {
+    pub fn buffer(mut self, buffer: *mut _screen_buffer) -> Self {
         self.buffer = buffer;
         self
     }

generator/src/lib.rs

@@ -300,6 +300,10 @@ fn is_opaque_type(ty: &str) -> bool {
             | "CAMetalLayer"
             | "IDirectFB"
             | "IDirectFBSurface"
+            | "_screen_buffer"
+            | "_screen_context"
+            | "_screen_window"
+            | "SECURITY_ATTRIBUTES"
     )
 }