Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release a new stable version? #382

Closed
Rua opened this issue Mar 3, 2021 · 8 comments
Closed

Release a new stable version? #382

Rua opened this issue Mar 3, 2021 · 8 comments

Comments

@Rua
Copy link
Contributor

Rua commented Mar 3, 2021

I'm interested in using Ash as a foundation for the Vulkano project (link). Vulkano needs the ability to load custom Vulkan libraries, which I see was added by #319, but not yet published as part of a stable version on crates.io. Would it be possible to release a new stable version sometime soonish, so that this feature becomes available? Thank you!

@Friz64
Copy link
Contributor

Friz64 commented Mar 3, 2021

See also: This discussion

@Rua
Copy link
Contributor Author

Rua commented Mar 3, 2021

Ah, nice! I'll close this then.

@Rua Rua closed this as completed Mar 3, 2021
@MarijnS95
Copy link
Collaborator

MarijnS95 commented Mar 3, 2021

That's a nice coincidence, I wondered about the same and asked this just days ago but GH discussions are rather hidden, there isn't even an "open discussions" number like there is for issues and PRs...

Things are moving and most open PRs addressing outstanding issues have been merged over the past few days. I'd take this opportunity again to ask @MaikKlein whether there are any outstanding blockers and issues that need to be addressed before the next release can be made. I'm sure the community is willing to expedite these to make it all the way to the end :)

Lastly vulkano-rs/vulkano#1500 sounds really cool! While I'm not the maintainer of Ash I'm sure we can accommodate to changes necessary for Vulkano, and you can always use the C functions directly from *Fn structs. Seems like the collaborative effort between ash and Vulkano is better spent maintaining a single, proper native wrapper crate 🎉!

@MaikKlein
Copy link
Member

I'll release a new version very soon. I am open for vulkano-rs/vulkano#1500 There have been talks about it a few years ago but nothing has happened yet. Either we move the function pointers to a new crate like ash-sys, or we put more things behind feature flags see #344

@Rua
Copy link
Contributor Author

Rua commented Mar 3, 2021

What do you mean regarding the function pointers? Ash seems quite usable for Vulkano as it is.

@MaikKlein
Copy link
Member

Ash seems quite usable for Vulkano as it is.

That is good to hear. Ash currently is a fairly large dependency. It comes with "high level" apis, builders etc. After the generator rewrite, you will be able opt out of most of these.

@Rua
Copy link
Contributor Author

Rua commented Mar 3, 2021

Hmm, is the size a major cause of slow compile times? Vulkano isn't all that fast to compile as it is, so maybe the extra time would disappear in the noise. Besides, cleaner, more idiomatic code in Vulkano might be worth it.

@MarijnS95
Copy link
Collaborator

MarijnS95 commented Mar 3, 2021

Compile-time of ash doesn't seem too bad, and it's only a one-off after clean builds when not actively developing on the crate itself.

Perhaps the CI (individual steps) is a clear enough indicator: https://github.com/MaikKlein/ash/actions?
EDIT: It's not clear at all because the CI is very slow (single or dualcore iirc) and inefficiently redownloading all crates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants