Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignoring unrecognized attributes (redux) #959

Open
oddhack opened this issue Nov 13, 2024 · 1 comment · May be fixed by #960
Open

Ignoring unrecognized attributes (redux) #959

oddhack opened this issue Nov 13, 2024 · 1 comment · May be fixed by #960

Comments

@oddhack
Copy link

oddhack commented Nov 13, 2024

We are getting this ash-generate CI error in the internal vulkan spec repo again (see e.g. https://gitlab.khronos.org/vulkan/vulkan/-/jobs/658141), which spreads out to affect more branches as people sync up their working branches to main. They are just warnings, but unfortunate when they result in every CI job coming up with the warning label.

@MarijnS95 could you remind me where you are WRT ignoring unrecognized attributes? If not addressed this is going to keep happening as we do come up with new attributes reasonably often to convey more semantic information about API entities.

@MarijnS95
Copy link
Collaborator

where you are WRT ignoring unrecognized attributes?

I initially went the inverse and made this a hard error in August, as we were previously ignoring it entirely which made it hard to backtrack errors: #930

As this is causing so many issues in upstream CI, I'll demote this to a more screaming error that is not actually aborting our process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants