Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stow --simulate should warn when -v is not specified #82

Open
ilyagr opened this issue Feb 28, 2021 · 6 comments · May be fixed by #87
Open

stow --simulate should warn when -v is not specified #82

ilyagr opened this issue Feb 28, 2021 · 6 comments · May be fixed by #87
Labels
easy enhancement
Milestone
Release 2.4.1

Comments

@ilyagr
Copy link
Contributor

ilyagr commented Feb 28, 2021 •
edited
Loading

At the default verbosity level, --simulate is quite useless, which confused me (see #81).

I think that either --simulate should imply -v, or the warning --simulate prints should be modified when the verbosity level is 0. It could say something like:

WARNING: in simulation mode so not modifying filesystem.
WARNING: The verbosity level is 0. Simulation results will not be shown.
@aspiers
Copy link
Owner

aspiers commented Feb 28, 2021

That's a great idea - thanks!

@aspiers aspiers added the easy label Feb 28, 2021
@ilyagr
Copy link
Contributor Author

ilyagr commented Feb 28, 2021

Glad to hear it! I also thought of slightly better wording:

WARNING: The verbosity level is 0. Use --verbose to see simulation results.

Thanks for maintaining stow, by the way!

@aspiers aspiers added this to the Release 2.3.2 milestone Apr 4, 2021
@gutierri
Copy link
Contributor

gutierri commented Apr 15, 2021 •
edited
Loading

I believe it would be better in case of invoking --simulate the default verbose value is 1 and always accept >= 1. Because the idea of the functionality is to visualize what would happen (right?).

Needing to fill in another parameter for this to work, can be a bit complicated. I even found out that --simulate is not on the manpage (#86).

@aspiers
Copy link
Owner

aspiers commented Apr 15, 2021

@gutierri commented on April 15, 2021 1:32 AM:

I believe it would be better in case of invoking --simulate the default verbose value is 1 and always accept >= 1. Because the idea of the functionality is to visualize what would happen (right?).

Yes I think I agree, and aim to do this for the next release - unless you want to submit a PR ;-)

@gutierri gutierri linked a pull request Apr 15, 2021 that will close this issue
Open
1 task
@aspiers aspiers modified the milestones: Release 2.4.0, Release 2.4.1 Apr 7, 2024
@aspiers
Copy link
Owner

aspiers commented Apr 7, 2024

All the critical work for 2.4.0 took WAY longer than I expected, so unfortunately I didn't get round to this yet; pushing to 2.4.1.

@gutierri
Copy link
Contributor

gutierri commented Apr 8, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy enhancement
Projects
None yet
Milestone
Release 2.4.1
Development

Successfully merging a pull request may close this issue.

--simulate opts with verbose value 1 gutierri/stow
3 participants
@aspiers @gutierri @ilyagr