-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving the multiband LS upstream #38
Comments
Sure, if the astropy community thinks the multiband code belongs upstream, I'd be fine with that. |
Is this work underway? I would certainly use it, and I see that some of the community are considering opening a new work "NewGatspy" to continue updates/work on gatspy with needs ramping up as part of the LSST. |
Yes, the LINCC group is doing some of this upstreaming. PR is here: astropy/astropy#14016 |
@dougbrn, could you comment on whether there is anything else left in this library, once the PR from above is merged? If not, I would propose to move all the open issues upstream, and archive the repo for now. |
Yeah, the multiband lombscargle going into astropy has everything from gatspy's multiband lombscargle. As far as what is left in the gatspy overall, we didn't include some of the other multiband gatspy functions in the port, such as the Multiband SuperSmoother or the Multiband Template Fitter. So unless those were ported in other work, gatspy may still be the only home for them. |
It would be lovely to see them being ported over, too, so everything is at one place. |
I suppose as all stuff gets moved out from here, we should move the |
If I understand the status correctly, it's only the multiband LS that is unique in gatspy, the rest had been moved upstream to astropy a couple of years ago.
@jakevdp - how would you feel to move the multi band as well and maybe archive this repo? It would make somewhat easier to communicate to the community that all your astroML & gatspy implementations has been moved, and receive the maintenance and occasional fixes and improvements in astropy.timeseries rather than at multiple places?
I volunteer to do the actual moving bit, but it's one of those cases where it feels better to ask for permission and opinion first rather than forgiveness after the fact.
The text was updated successfully, but these errors were encountered: