Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To_hipscat fails with a catalog where columns has been added #282

Closed
nevencaplar opened this issue Apr 19, 2024 · 2 comments
Closed

To_hipscat fails with a catalog where columns has been added #282

nevencaplar opened this issue Apr 19, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@nevencaplar
Copy link
Member

As shown during the monthly hipscat working group meeting, the following sniper fails (last line, when uncommented), probably because of the problems in the metadata.

dummy

@nevencaplar nevencaplar added the bug Something isn't working label Apr 19, 2024
@nevencaplar nevencaplar moved this to Todo in HATS / LSDB Apr 25, 2024
@camposandro
Copy link
Collaborator

camposandro commented May 2, 2024

Hi @nevencaplar! I executed this snippet on both test data and ZTF (except for the loading of the 'm_ini' column) and I was not able to reproduce the issue saving the catalog with to_hipscat. @smcguire-cmu has access to the trilegal-flip catalog used here and, from what I could understand, this workflow worked as expected for him too. Do you have any idea of what the error was about?

@smcguire-cmu
Copy link
Contributor

smcguire-cmu commented May 2, 2024

It's because this code was executed with the map_partitions method defined in the image, which I think doesn't properly update the dask meta and causes issues from that. Our testing used the map_partitions that was recently added to LSDB in #290 that does update the meta. I think we can close this issue, that using the new map_partitionsin lsdb fixes things.

@github-project-automation github-project-automation bot moved this from Todo to Done in HATS / LSDB May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

3 participants