-
-
Notifications
You must be signed in to change notification settings - Fork 130
Open
Labels
analysisSpectral analysis/measurement toolsSpectral analysis/measurement tools
Milestone
Description
This issue builds off of discussions in #235, #314, and #324.
To summarize: #324 implemented a "quick and dirty" way of doing line flux measurements - basically it only considers whole-pixels. The "right" way is to also include the fractions of pixels that are on the edges. For a more in-depth discussion of this with math and everything see
#314 (comment) .
This issue is to improve the line_flux
function to account for the fractional edge pixel. I think the linked comment above lays that out reasonably thoroughly, but if more clarification is needed/changes proposed, we can hash it out in this issue.
By reference this will also affect equivalent_width
, SNR
, etc., I think which is a good thing.
Metadata
Metadata
Assignees
Labels
analysisSpectral analysis/measurement toolsSpectral analysis/measurement tools