Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Modelina CLI that can be extended by AsyncAPI CLI #1724

Closed
jonaslagoni opened this issue Jan 4, 2024 · 7 comments
Closed

Introduce Modelina CLI that can be extended by AsyncAPI CLI #1724

jonaslagoni opened this issue Jan 4, 2024 · 7 comments
Assignees
Labels
area/typescript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. enhancement New feature or request good first issue Good for newcomers

Comments

@jonaslagoni
Copy link
Member

Reason/Context

Currently, you can use the AsyncAPI CLI to generate models with Modelina, however, one limitation is that only AsyncAPI inputs are supported.

A better setup would be to have the AsyncAPI CLI extend the Modelina CLI which has no restrictions on inputs. That way we can reuse most if not all the implementation while keeping everything Modelina-related in this repo.

While this issue is a good first issue, it is gonna take quite a time to implement the initial implementation, because some research and trial and error need to be done.

Here is the TODO I would suggest to follow to solve this issue:

@jonaslagoni jonaslagoni added enhancement New feature or request good first issue Good for newcomers area/typescript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. labels Jan 4, 2024
@ankur0904
Copy link
Contributor

@jonaslagoni I am happy to work on this issue and the idea is very useful to encourage reusability.

@jonaslagoni
Copy link
Member Author

Hey @ankur0904 any progress or update? 🙂

@ankur0904
Copy link
Contributor

@jonaslagoni My sincere apologies for the delayed response. Unfortunately, I faced unexpected challenges that prevented me from making progress on the issue.

@devilkiller-ag
Copy link
Member

Hi @ankur0904, are you still working on this one? If not, @jonaslagoni I would like to work on this.

@ankur0904
Copy link
Contributor

@devilkiller-ag Please go ahead as I am currently not working on this issue.

@devilkiller-ag
Copy link
Member

Thanks @ankur0904! @jonaslagoni I will study a little bit about this issue and let you know my initial findings.

@jonaslagoni
Copy link
Member Author

jonaslagoni commented Apr 26, 2024

I think we can close this issue, as the remaining effort is already under way in asyncapi/cli#1376

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/typescript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants