Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump node-fetch to 2.7.0 #1048

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore(deps): bump node-fetch to 2.7.0 #1048

wants to merge 2 commits into from
+22 −3

Conversation

drodil
Copy link

@drodil drodil commented Aug 2, 2024

Description

  • Use 2.7.0+ version of node-fetch that fixes bug with NodeJS20, see issue for more details

Related issue(s)

fixes #1047

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 2, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 78a1625

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions[bot]
github-actions bot reviewed Aug 2, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@drodil drodil mentioned this pull request Aug 5, 2024
Open
2 tasks
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

jonaslagoni
jonaslagoni requested changes Oct 28, 2024
View reviewed changes
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure you add a changeset 🙂 #1048 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@jonaslagoni jonaslagoni jonaslagoni requested changes

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu magicmatatjahu is a code owner

@smoya smoya Awaiting requested review from smoya smoya is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Using old version of node-fetch causes issues with Node20
2 participants
@drodil @jonaslagoni