From faed840be8382ba73a22647e2d8c000f255d5c4a Mon Sep 17 00:00:00 2001 From: Michael <2231370+Blasz@users.noreply.github.com> Date: Mon, 27 Feb 2023 10:33:34 +1000 Subject: [PATCH] Upgrade node from v16 to v18 (#216) --- .circleci/config.yml | 4 ++-- .nvmrc | 2 +- CONTRIBUTING.md | 2 +- Dockerfile | 2 +- package.json | 2 +- yarn.lock | 8 ++++---- 6 files changed, 10 insertions(+), 10 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index f280723e..1cbb467d 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -3,7 +3,7 @@ version: 2 jobs: build: docker: - - image: cimg/node:16.18.1 + - image: cimg/node:18.14.2 working_directory: ~/repo steps: - checkout @@ -20,7 +20,7 @@ jobs: unit_test: docker: - - image: cimg/node:16.18.1 + - image: cimg/node:18.14.2 working_directory: ~/repo steps: - checkout diff --git a/.nvmrc b/.nvmrc index a2d511af..e06fc80f 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -16.18.1 \ No newline at end of file +18.14.2 \ No newline at end of file diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index e7e55708..7a022497 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -11,7 +11,7 @@ First you'll need to have a repo to test in that is under your name. So [create Now you'll need to set up Pipelines. On the sidebar you should see a `Pipelines` button, click that. It will ask which kind of build you wish to create, select `Javascript`. It should have a sample config in front of you. Replace it with: ```yml -image: node:12 +image: node:18 pipelines: default: # This is the default branch build diff --git a/Dockerfile b/Dockerfile index d12fd3f9..98f9047f 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,4 +1,4 @@ -FROM node:16.18.1-alpine +FROM node:18.14.2-alpine@sha256:0d2712ac2b2c1149391173de670406f6e3dbdb1b2ba44e8530647e623e0e1b17 WORKDIR /opt/service diff --git a/package.json b/package.json index e52e3ad6..2cbef88e 100644 --- a/package.json +++ b/package.json @@ -50,7 +50,7 @@ "@types/ioredis-mock": "^5.6.0", "@types/jest": "^26.0.5", "@types/joi": "^14.3.4", - "@types/node": "^15.0.2", + "@types/node": "^18.14.1", "@types/p-retry": "^2.0.0", "@types/passport": "^1.0.6", "@types/passport-http": "^0.3.9", diff --git a/yarn.lock b/yarn.lock index 0426eb73..5cc3d8d9 100644 --- a/yarn.lock +++ b/yarn.lock @@ -3483,10 +3483,10 @@ resolved "https://packages.atlassian.com/api/npm/npm-remote/@types/node/-/node-16.11.56.tgz#dcbb617669481e158e0f1c6204d1c768cd675901" integrity sha512-aFcUkv7EddxxOa/9f74DINReQ/celqH8DiB3fRYgVDM2Xm5QJL8sl80QKuAnGvwAsMn+H3IFA6WCrQh1CY7m1A== -"@types/node@^15.0.2": - version "15.14.9" - resolved "https://packages.atlassian.com/api/npm/npm-remote/@types/node/-/node-15.14.9.tgz#bc43c990c3c9be7281868bbc7b8fdd6e2b57adfa" - integrity sha512-qjd88DrCxupx/kJD5yQgZdcYKZKSIGBVDIBE1/LTGcNm3d2Np/jxojkdePDdfnBHJc5W7vSMpbJ1aB7p/Py69A== +"@types/node@^18.14.1": + version "18.14.1" + resolved "https://packages.atlassian.com/api/npm/npm-remote/@types/node/-/node-18.14.1.tgz#90dad8476f1e42797c49d6f8b69aaf9f876fc69f" + integrity sha512-QH+37Qds3E0eDlReeboBxfHbX9omAcBCXEzswCu6jySP642jiM3cYSIkU/REqwhCUqXdonHFuBfJDiAJxMNhaQ== "@types/normalize-package-data@^2.4.0": version "2.4.1"