Skip to content

Secure Headers are not in use #2491

@mboudreau

Description

@mboudreau
Contributor

Was looking at the codebase for some stuff I've done in the past and noticed this:

setupFrontendApp(app);
secureHeaders(app);

Since it's using the express use concept, and that it's "using" after the router is setup, that means that all secure headers are essentially ignored until after the routes are completed, which means that this isn't securing anything.

I'm not sure what's being accomplished by having the security headers in a separate function since it's only used once? Why not just add it inline with all other express app settings right before the router is used?

skeletor-until-we-meet-again

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @mboudreau

        Issue actions

          Secure Headers are not in use · Issue #2491 · atlassian/github-for-jira