fix alias dead process test

Signed-off-by: Mateusz Front <[email protected]>

Author: mat-hek

libs/estdlib/src/erlang.erl

@@ -1179,11 +1179,11 @@ monitor(_Type, _PidOrPort) ->
 %% @param   Options     monitor options
 %% @returns a monitor reference
 %% @doc     Creates a monitor and allows passing additional options.
-%%          Currently, only the `{alias, AliasMode}` option is supported. Passing it
-%%          makes the monitor also an alias on the calling process (see `alias/0`).
-%%          `AliasMode` defines the behaviour of the alias:
-%%          - explicit_unalias - the alias can be only removed with `unalias/1`,
-%%          - demonitor - the alias is also removed when `demonitor/1` is called
+%%          Currently, only the `{alias, AliasMode}' option is supported. Passing it
+%%          makes the monitor also an alias on the calling process (see `alias/0').
+%%          `AliasMode' defines the behaviour of the alias:
+%%          - explicit_unalias - the alias can be only removed with `unalias/1',
+%%          - demonitor - the alias is also removed when `demonitor/1' is called
 %%                        on the monitor,
 %%          - reply_demonitor - the alias is also removed after a first message
 %%                              is sent via it.
@@ -1611,8 +1611,8 @@ raise(_Class, _Reason, _Stacktrace) ->
 %% @returns A reference aliasing the calling process.
 %% @doc     Creates an alias for the callling process. The alias can be used
 %%          to send messages to the process like the PID. The alias can also be
-%%          created along with a monitor - see `monitor/3`. The alias can be
-%%          removed by calling `unalias/1`.
+%%          created along with a monitor - see `monitor/3'. The alias can be
+%%          removed by calling `unalias/1'.
 %% @end
 %%-----------------------------------------------------------------------------
 -spec alias() -> Alias when Alias :: reference().
@@ -1621,8 +1621,8 @@ alias() ->
 
 %%-----------------------------------------------------------------------------
 %% @param   Alias the alias to be removed.
-%% @returns `true` if alias was removed, `false` if it was not found
-%% @doc     Removes process alias. See `alias/0` for more information.
+%% @returns `true' if alias was removed, `false' if it was not found
+%% @doc     Removes process alias. See `alias/0' for more information.
 %% @end
 %%-----------------------------------------------------------------------------
 -spec unalias(Alias) -> boolean() when Alias :: reference().

src/libAtomVM/term.h

@@ -1871,7 +1871,7 @@ static inline bool term_is_nomatch_binary_pos_len(BinaryPosLen pos_len)
 
 static inline BinaryPosLen term_nomatch_binary_pos_len(void)
 {
-    return (BinaryPosLen) { .pos = -1, .len = -1 };
+    return (BinaryPosLen){ .pos = -1, .len = -1 };
 }
 
 /**

tests/erlang_tests/test_binary_to_term.erl

@@ -1141,7 +1141,7 @@ test_encode_process_ref() ->
     AliasesAvailable = is_atomvm_or_otp_version_at_least("23"),
     if
         AliasesAvailable ->
-            ProcessRef = alias(),
+            ProcessRef = erlang:alias(),
             ProcessRef = binary_to_term(term_to_binary(ProcessRef)),
             ok;
         true ->

tests/erlang_tests/test_monitor.erl

@@ -46,6 +46,7 @@ start() ->
             ok = test_multiple_aliases(),
             ok = test_multiple_unaliases(),
             ok = test_unalias_from_wrong_process(),
+            ok = test_monitor_alias_dead_process(),
             ok = test_monitor_multiple_aliases_monitors(fun spawn_monitor/2),
             ok = test_monitor_multiple_aliases_monitors(fun spawn_and_monitor/2),
             ok = test_monitor_alias_demonitor(fun spawn_monitor/2),
@@ -56,8 +57,6 @@ start() ->
             ok = test_monitor_alias_reply_demonitor(fun spawn_and_monitor/2),
             ok = test_monitor_down_alias(fun spawn_monitor/2),
             ok = test_monitor_down_alias(fun spawn_and_monitor/2),
-            ok = test_monitor_alias_dead_process(fun spawn_monitor/2),
-            ok = test_monitor_alias_dead_process(fun spawn_and_monitor/2),
             ok;
         true ->
             ok
@@ -347,14 +346,15 @@ test_monitor_multiple_aliases_monitors(SpawnFun) ->
     {'DOWN', Mon4, process, P, normal} = recv_one(),
     ok.
 
-test_monitor_alias_dead_process(SpawnFun) ->
-    Noop = fun() -> ok end,
-    {P1, Mon1} = SpawnFun(Noop, [{alias, demonitor}]),
-    {'DOWN', Mon1, process, P1, normal} = recv_one(),
-    {P2, Mon2} = SpawnFun(Noop, [{alias, reply_demonitor}]),
-    {'DOWN', Mon2, process, P2, normal} = recv_one(),
-    {P3, Mon3} = SpawnFun(Noop, [{alias, explicit_unalias}]),
-    {'DOWN', Mon3, process, P3, normal} = recv_one(),
+test_monitor_alias_dead_process() ->
+    {P, Mon0} = spawn_opt(fun() -> ok end, [monitor]),
+    {'DOWN', Mon0, process, P, normal} = recv_one(),
+    Mon1 = erlang:monitor(process, P, [{alias, demonitor}]),
+    {'DOWN', Mon1, process, P, noproc} = recv_one(),
+    Mon2 = erlang:monitor(process, P, [{alias, reply_demonitor}]),
+    {'DOWN', Mon2, process, P, noproc} = recv_one(),
+    Mon3 = erlang:monitor(process, P, [{alias, explicit_unalias}]),
+    {'DOWN', Mon3, process, P, noproc} = recv_one(),
     ok.
 
 spawn_monitor(LoopFun, Opts) ->