Merge pull request #2042 from pguyot/w51/fix-timeout-estdlib

Add receive timeouts to avoid the 20-30 mins global timeouts

These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).

SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

Author: bettio

tests/libs/estdlib/test_gen_tcp.erl

@@ -50,6 +50,7 @@ test_echo_server(SpawnControllingProcess) ->
     receive
         ready ->
             ok
+    after 1000 -> throw({timeout, test_echo_server, ?LINE})
     end,
 
     test_send_receive(Port, 10, SpawnControllingProcess),
@@ -84,6 +85,7 @@ echo(Pid, Socket) ->
             echo(Pid, Socket);
         SomethingElse ->
             erlang:display({echo, unexpected_message, SomethingElse})
+    after 1000 -> throw({timeout, echo, ?LINE})
     end.
 
 test_send_receive(Port, N, SpawnControllingProcess) ->
@@ -92,17 +94,19 @@ test_send_receive(Port, N, SpawnControllingProcess) ->
         false ->
             loop(Socket, N);
         true ->
-            Pid = spawn(fun() ->
+            Pid = spawn_link(fun() ->
                 receive
                     {Parent, go} ->
                         loop(Socket, N),
                         Parent ! done
+                after 5000 -> throw({timeout, test_send_receive, ?LINE})
                 end
             end),
             gen_tcp:controlling_process(Socket, Pid),
             Pid ! {self(), go},
             receive
                 done -> ok
+            after 5000 -> throw({timeout, test_send_receive, ?LINE})
             end
     end,
 
@@ -122,6 +126,7 @@ loop(Socket, I) ->
             ok;
         {tcp, _OtherSocket, _OtherPacket} ->
             loop(Socket, I - 1)
+    after 1000 -> throw({timeout, loop, ?LINE})
     end.
 
 test_listen_connect_parameters() ->
@@ -218,6 +223,7 @@ test_listen_connect_parameters(
     receive
         server_done ->
             ok
+    after 1000 -> throw({timeout, test_listen_connect_parameters, ?LINE})
     end,
 
     ok = gen_tcp:close(Socket),

tests/libs/estdlib/test_tcp_socket.erl

@@ -197,6 +197,8 @@ start_echo_server(_Port) ->
     receive
         ready ->
             ok
+    after 10000 ->
+        error({timeout, ?MODULE, ?LINE})
     end,
 
     {ListenSocket, ActualPort}.
@@ -568,6 +570,8 @@ test_abandon_select() ->
     receive
         done ->
             ok
+    after 10000 ->
+        error({timeout, ?MODULE, ?LINE})
     end,
 
     erlang:garbage_collect(),