Updated GH workflow (simpler matrix, better coverage)

Author: fkleuver

.github/workflows/ci.yml

@@ -7,19 +7,16 @@ on:
 
 permissions:
   contents: read
+  pull-requests: write
 
 concurrency:
   group: ci-${{ github.ref }}
   cancel-in-progress: true
 
 jobs:
-  test:
-    name: Test (Node ${{ matrix.node }})
+  ci:
+    name: Test & Coverage
     runs-on: ubuntu-latest
-    strategy:
-      fail-fast: false
-      matrix:
-        node: [18.x, 20.x, 22.x]
     steps:
       - uses: actions/checkout@v4
 
@@ -30,41 +27,21 @@ jobs:
 
       - uses: actions/setup-node@v4
         with:
-          node-version: ${{ matrix.node }}
+          node-version: 20.x
           cache: pnpm
 
       - name: Install dependencies
-        run: pnpm install --frozen-lockfile
+        run: pnpm install
 
       - name: Build and test
         run: pnpm test:spec
 
-  coverage:
-    name: Coverage (domain suite)
-    runs-on: ubuntu-latest
-    needs: test
-    steps:
-      - uses: actions/checkout@v4
-
-      - uses: pnpm/action-setup@v4
-        with:
-          version: 9
-          run_install: false
-
-      - uses: actions/setup-node@v4
-        with:
-          node-version: 20.x
-          cache: pnpm
-
-      - name: Install dependencies
-        run: pnpm install --frozen-lockfile
-
-      - name: Run coverage
+      - name: Run coverage (domain suite)
         run: |
           set -o pipefail
           pnpm test:domain:cov | tee coverage/typecheck/coverage.log
 
-      - name: Coverage summary
+      - name: Coverage summary (job)
         run: |
           {
             echo "## Coverage (domain suite)";
@@ -77,3 +54,67 @@ jobs:
         with:
           name: coverage-typecheck
           path: coverage/typecheck
+
+      - name: Comment coverage on PR
+        if: github.event_name == 'pull_request'
+        uses: actions/github-script@v7
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          script: |
+            const fs = require('fs');
+            const path = 'coverage/typecheck/coverage-final.json';
+            const coverage = JSON.parse(fs.readFileSync(path, 'utf8'));
+
+            const keys = ['lines', 'statements', 'functions', 'branches'];
+            const totals = Object.values(coverage).reduce((acc, file) => {
+              for (const key of keys) {
+                acc[key].total += file[key].total;
+                acc[key].covered += file[key].covered;
+              }
+              return acc;
+            }, {
+              lines: { total: 0, covered: 0 },
+              statements: { total: 0, covered: 0 },
+              functions: { total: 0, covered: 0 },
+              branches: { total: 0, covered: 0 },
+            });
+
+            const fmt = ({ covered, total }) =>
+              total === 0 ? 'n/a' : `${((covered / total) * 100).toFixed(2)}% (${covered}/${total})`;
+
+            const header = '## Coverage (domain suite)';
+            const body = [
+              header,
+              '',
+              `- Lines: ${fmt(totals.lines)}`,
+              `- Statements: ${fmt(totals.statements)}`,
+              `- Functions: ${fmt(totals.functions)}`,
+              `- Branches: ${fmt(totals.branches)}`,
+              '',
+              '_Generated by CI_',
+            ].join('\n');
+
+            const { data: comments } = await github.rest.issues.listComments({
+              issue_number: context.issue.number,
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+            });
+            const existing = comments.find(
+              (c) => c.user?.login === 'github-actions[bot]' && c.body?.startsWith(header)
+            );
+
+            if (existing) {
+              await github.rest.issues.updateComment({
+                comment_id: existing.id,
+                owner: context.repo.owner,
+                repo: context.repo.repo,
+                body,
+              });
+            } else {
+              await github.rest.issues.createComment({
+                issue_number: context.issue.number,
+                owner: context.repo.owner,
+                repo: context.repo.repo,
+                body,
+              });
+            }