Regression: Types not exposed

[mgagliardo91]

The change located at https://github.com/authzed/authzed-node/pull/197/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R16-R26 led to a break in our usage, as the types are no longer accessible at the previous location.

In our typescript application, we are importing the generated types such as:

import {
  CheckPermissionRequest,
  CheckPermissionResponse,
  CheckPermissionResponse_Permissionship,
  LookupResourcesRequest,
  Relationship,
  RelationshipFilter,
  RelationshipUpdate,
} from '@authzed/authzed-node/dist/src/v1'

With the change that was put in place, these types are no longer accessible via the package exports. I am unsure how to access them at all, in fact.

Any ideas on how we can bump to the latest version with the change that was previously deployed?

[mgagliardo91]

cc @tstirrat15

[tstirrat15]

@mgagliardo91 you can currently grab them by doing this:

import { v1 } from '@authzed/authzed-node'

const thing: v1.CheckPermissionRequest = {}

I agree this isn't ideal; the only reason I hesitate to flatten them is that the different API versions are technically different namespaces.

I can do some research into namespacing types too.

[tstirrat15]

Hmm... Looks like TS will complain if you attempt to include multiple things in the same namespace that have a name collision. That makes me feel better about flattening.

We also try and keep the names distinct between different services and APIs, so ideally we're not running into this at all.

[mgagliardo91]

@tstirrat15 that makes sense. I think you can expose each version as its own root export as well, which should give you something like:

import {
  CheckPermissionRequest,
  CheckPermissionResponse,
  CheckPermissionResponse_Permissionship,
  LookupResourcesRequest,
  Relationship,
  RelationshipFilter,
  RelationshipUpdate,
} from '@authzed/authzed-node/v1'

But I think we are okay with the explicit namespace alias.

Thanks for your help!

[tstirrat15]

Oh! That's a good point. I'll have a look at that.