refactor: do not ignore caching errors (#411)

Author: clostao

backend/__tests__/e2e/objects/object.spec.ts

@@ -11,6 +11,8 @@ import {
 import { uploadFile } from '../../utils/uploads.js'
 import { jest } from '@jest/globals'
 import { v4 } from 'uuid'
+import { downloadService } from '../../../src/services/download/index.js'
+import { Readable } from 'stream'
 
 describe('Object', () => {
   let user: UserWithOrganization
@@ -65,9 +67,18 @@ describe('Object', () => {
   })
 
   it('isArchived should return true for archived object', async () => {
+    const downloadSpy = jest.spyOn(downloadService, 'download')
+    downloadSpy.mockResolvedValueOnce(
+      new Readable({
+        read: async function () {
+          this.push(null)
+        },
+      }),
+    )
     await ObjectUseCases.onObjectArchived(fileCid)
     const isArchived = await ObjectUseCases.isArchived(fileCid)
     expect(isArchived).toBe(true)
+    expect(downloadSpy).toHaveBeenCalledTimes(1)
   })
 
   it('should get listed in user objects', async () => {

backend/src/useCases/objects/object.ts

@@ -327,6 +327,7 @@ const populateCaches = async (cid: string) => {
       logger.warn(
         `Failed to download object (cid=${cid}) from DB after archival check: ${e}`,
       )
+      throw e
     })
 }