Fix EC2 to RabbitMQ connection issue

[DaMandal0rian]

PR Type

Bug fix, Enhancement

---

Description

• Fixed EC2 to RabbitMQ connection by updating security group rules.

• Replaced cidr_blocks with security_groups for RabbitMQ ingress.

• Added egress rules in EC2 security group for RabbitMQ ports.

• Improved security by specifying traffic sources and destinations.

---

Changes walkthrough 📝

	Relevant files
Bug fix	broker.tf Update RabbitMQ security group ingress rules                          auto-drive/broker.tf Updated RabbitMQ ingress rules to use security_groups. Removed cidr_blocks for RabbitMQ ingress rules. Allowed traffic from EC2 security group to RabbitMQ. +8/-8
Enhancement	main.tf Add egress rules for RabbitMQ in EC2 security group            auto-drive/main.tf Added egress rules for RabbitMQ ports in EC2 security group. Allowed traffic to private subnets for RabbitMQ communication. Enhanced outbound traffic rules for RabbitMQ. +15/-0

---

Need help?

Type /help how to ... in the comments thread for any questions about PR-Agent usage.

Check out the documentation for more information.

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Security Group Configuration Ensure that replacing cidr_blocks with security_groups for RabbitMQ ingress does not inadvertently restrict or allow unintended traffic. Validate that the referenced security group (aws_security_group.auto_drive_sg.id) is correctly configured. from_port = 5671 to_port = 5671 protocol = "tcp" security_groups = [aws_security_group.auto_drive_sg.id] # Allow traffic from EC2 server's security group } ingress { from_port = 5672 to_port = 5672 protocol = "tcp" security_groups = [aws_security_group.auto_drive_sg.id] # Allow traffic from EC2 server's security group Egress Rules for RabbitMQ Verify that the added egress rules for RabbitMQ ports (5671 and 5672) in the EC2 security group are necessary and do not introduce unintended exposure to private subnets. # Allow outbound traffic to RabbitMQ broker egress { from_port = 5671 to_port = 5671 protocol = "tcp" cidr_blocks = var.private_subnet_cidrs # Allow traffic to private subnets } egress { from_port = 5672 to_port = 5672 protocol = "tcp" cidr_blocks = var.private_subnet_cidrs # Allow traffic to private subnets

[github-actions]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Validate security group references Ensure that the security_groups attribute in the ingress rules is correctly referencing an existing and valid security group ID to avoid potential misconfigurations or runtime errors. auto-drive/broker.tf [108] -security_groups = [aws_security_group.auto_drive_sg.id] # Allow traffic from EC2 server's security group +security_groups = [aws_security_group.auto_drive_sg.id] # Ensure this references a valid security group ID Suggestion importance[1-10]: 7 __ Why: The suggestion is valid as it emphasizes the importance of ensuring the security_groups attribute references a valid security group ID, which is critical to avoid misconfigurations. However, it is not actionable as it only asks for verification without proposing concrete changes.	Medium
	Validate private subnet CIDRs Verify that the cidr_blocks attribute in the egress rules accurately represents the intended private subnet CIDRs to prevent unintended traffic exposure. auto-drive/main.tf [92] -cidr_blocks = var.private_subnet_cidrs # Allow traffic to private subnets +cidr_blocks = var.private_subnet_cidrs # Ensure this matches the intended private subnet CIDRs Suggestion importance[1-10]: 7 __ Why: This suggestion is relevant because verifying the cidr_blocks attribute ensures that the egress rules align with the intended private subnet CIDRs, preventing unintended traffic exposure. However, it is not actionable and only asks for verification, which slightly reduces its impact.	Medium

[clostao]

LGTM

[DaMandal0rian]

closes #419