Merge pull request #3480 from autonomys/fix-unlock-failure

Fix unlock failure due to missing share price

Author: NingLin-P

crates/pallet-domains/src/benchmarking.rs

@@ -759,9 +759,16 @@ mod benchmarks {
         do_finalize_domain_epoch_staking::<T>(domain_id)
             .expect("finalize domain staking should success");
 
+        let current_domain_epoch_index = DomainStakingSummary::<T>::get(domain_id)
+            .expect("domain must initialized")
+            .current_epoch_index;
         Withdrawals::<T>::try_mutate(operator_id, nominator.clone(), |maybe_withdrawal| {
             let withdrawal = maybe_withdrawal.as_mut().unwrap();
-            do_convert_previous_epoch_withdrawal::<T>(operator_id, withdrawal)?;
+            do_convert_previous_epoch_withdrawal::<T>(
+                operator_id,
+                withdrawal,
+                current_domain_epoch_index,
+            )?;
             assert_eq!(withdrawal.withdrawals.len() as u32, w);
             Ok::<(), StakingError>(())
         })

crates/pallet-domains/src/lib.rs

@@ -754,6 +754,13 @@ mod pallet {
     #[pallet::storage]
     pub type SkipBalanceChecks<T> = StorageValue<_, BTreeSet<DomainId>, ValueQuery>;
 
+    /// TODO: remove after all "missing-share-price" withdrawal is unlocked on Taurus
+    /// Storage that hold a domain epoch, for epoch that happen before it, the share price may
+    /// be missing due to https://github.com/autonomys/subspace/issues/3459, in this case, we
+    /// use the current share price as the default.
+    #[pallet::storage]
+    pub type AllowedDefaultSharePriceEpoch<T> = StorageValue<_, DomainEpoch, OptionQuery>;
+
     #[derive(TypeInfo, Encode, Decode, PalletError, Debug, PartialEq)]
     pub enum BundleError {
         /// Can not find the operator for given operator id.

crates/pallet-domains/src/migrations.rs

@@ -25,12 +25,16 @@ pub struct VersionUncheckedMigrateV3ToV4<T>(sp_std::marker::PhantomData<T>);
 impl<T: Config> UncheckedOnRuntimeUpgrade for VersionUncheckedMigrateV3ToV4<T> {
     fn on_runtime_upgrade() -> Weight {
         domain_balance_check_migration_migration::migrate_domain_balance_check::<T>()
+            .saturating_add(
+                domain_balance_check_migration_migration::migrate_domain_share_price_check::<T>(),
+            )
     }
 }
 
 mod domain_balance_check_migration_migration {
     use super::{BTreeSet, Config};
-    use crate::SkipBalanceChecks;
+    use crate::staking::DomainEpoch;
+    use crate::{AllowedDefaultSharePriceEpoch, DomainStakingSummary, SkipBalanceChecks};
     use frame_support::pallet_prelude::Weight;
     use sp_core::Get;
     use sp_domains::DomainId;
@@ -41,4 +45,16 @@ mod domain_balance_check_migration_migration {
         SkipBalanceChecks::<T>::put(list);
         T::DbWeight::get().reads_writes(0, 1)
     }
+
+    pub(super) fn migrate_domain_share_price_check<T: Config>() -> Weight {
+        // 1 read and 1 write
+        let domain_id = DomainId::new(0);
+        if let Some(staking_summary) = DomainStakingSummary::<T>::get(domain_id) {
+            AllowedDefaultSharePriceEpoch::<T>::put(DomainEpoch::from((
+                domain_id,
+                staking_summary.current_epoch_index,
+            )));
+        }
+        T::DbWeight::get().reads_writes(1, 1)
+    }
 }