-
Notifications
You must be signed in to change notification settings - Fork 256
Open
Labels
executionSubspace executionSubspace executionnice-to-haveNon-critical but nice to haveNon-critical but nice to have
Description
Currently our benchmark script only updates the weights for production runtimes. For consistency, and to detect bugs caused by particular weight values, it should also update test runtime weights.
Steps to fix
- Add the test weights to the benchmark script
- Check in the script that all weights were regenerated, by searching for
DATE:and checking they're all the same - Open a PR with the regenerated weights
Weights to fix
- https://github.com/autonomys/subspace/blob/main/crates/pallet-rewards/src/weights.rs
- https://github.com/autonomys/subspace/blob/main/crates/pallet-rewards/src/weights.rs
- https://github.com/autonomys/subspace/blob/main/crates/pallet-subspace/src/extensions/weights.rs
- https://github.com/autonomys/subspace/blob/main/domains/pallets/messenger/src/weights.rs
- https://github.com/autonomys/subspace/blob/main/crates/pallet-domains/src/weights.rs
- https://github.com/autonomys/subspace/blob/main/domains/pallets/executive/src/weights.rs
- https://github.com/autonomys/subspace/blob/main/domains/pallets/transporter/src/weights.rs
- https://github.com/autonomys/subspace/blob/main/crates/pallet-runtime-configs/src/weights.rs
- https://github.com/autonomys/subspace/blob/main/crates/pallet-subspace/src/weights.rs
- https://github.com/autonomys/subspace/blob/main/domains/pallets/auto-id/src/weights.rs
Special Cases
Needs to be manually checked first time, because it has no DATE:
Inconsistent module name:
The module name for weights_from_domains should also be renamed to match production:
subspace/domains/runtime/evm/src/lib.rs
Line 632 in 93b12c5
| weights::pallet_messenger_between_domains_extension::WeightInfo<Runtime>, |
Further work
Ideally, this test code would only be compiled when we're running tests, via a test-only feature.
We should also be only implementing these test weights for test runtimes, and not for all runtimes, so we can't accidentally use them incorrectly.
Metadata
Metadata
Assignees
Labels
executionSubspace executionSubspace executionnice-to-haveNon-critical but nice to haveNon-critical but nice to have