Skip to content

Update test-only weights using the benchmark script #3702

@teor2345

Description

@teor2345

Currently our benchmark script only updates the weights for production runtimes. For consistency, and to detect bugs caused by particular weight values, it should also update test runtime weights.

Steps to fix

  1. Add the test weights to the benchmark script
  2. Check in the script that all weights were regenerated, by searching for DATE: and checking they're all the same
  3. Open a PR with the regenerated weights

Weights to fix

Special Cases

Needs to be manually checked first time, because it has no DATE:

Inconsistent module name:

The module name for weights_from_domains should also be renamed to match production:

weights::pallet_messenger_between_domains_extension::WeightInfo<Runtime>,

Further work

Ideally, this test code would only be compiled when we're running tests, via a test-only feature.

We should also be only implementing these test weights for test runtimes, and not for all runtimes, so we can't accidentally use them incorrectly.

Metadata

Metadata

Assignees

No one assigned

    Labels

    executionSubspace executionnice-to-haveNon-critical but nice to have

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions