Skip to content

Initial Windows support for AppIconExtractor processor #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

NickETH
Copy link

@NickETH NickETH commented Dec 1, 2023

This PR extends the AppIconExtractor processor to work with Windows icons from EXE- and MSI-files.

@haircut
Copy link
Contributor

haircut commented Aug 8, 2024

First, apologies for the long delay in review @NickETH.

This is interesting work. Thank you for taking this on!

I have no experience running AutoPkg on Windows to build Windows software; would you mind providing an example recipe demonstrating your extension to this processor?

@NickETH
Copy link
Author

NickETH commented Aug 23, 2024

Hi Mattew,
sorry for the delayed answer, was on vacation.
Have quite a few examples now, as we use it to generate the icons for our kiosk.
E.g: https://github.com/autopkg/NickETH-recipes/blob/master/Claris/FileMakerPro-Win64.build.recipe.yaml
Works really well. Great idea and work on your side, BTW. :-)
Most important would be to make sure, that my code does not affect the OSX part.
Nick

@NickETH
Copy link
Author

NickETH commented Dec 29, 2024

Hi Mattew,
this is still open.
Do you think, you could commit that PR in near future?
Of course, i could also do a Windows only version.
But this would be the second-best option, IMHO.
Nick

@NickETH
Copy link
Author

NickETH commented Apr 7, 2025

Hi Mattew,
what about this PR?
Would be cool, if you could merge it.
Nick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants