Skip to content
This repository was archived by the owner on Nov 14, 2022. It is now read-only.
This repository was archived by the owner on Nov 14, 2022. It is now read-only.

Add backup-manual-submission script, when database lookup fails #103

@Pasarus

Description

@Pasarus

Issue raised by: developer

What?
Using manual_submission.py only needs instrument name and run number which is great. However, this relies on database lookup either available in autoreduction database or ISIS Data Catalogue. When this not available this fails.

Example of this from today is running:

python manual_submission.py HRPD 78261

which resulted in output:

Logging into ICAT
Logging into Database
Logging into ActiveMQ
Cannot find datafile for run_number 78261 in Auto-reduction database. Will try ICAT...
Cannot find datafile 'HRP78261.nxs' in ICAT. Will try with zeros in front of run number.
Cannot find datafile 'HRP00078261.nxs' in ICAT. Exiting...

HRP78261.nxs is neither available in autoreduction database nor in ICAT (although it should be, but ingestion to ICAT does not always work), but it exist on the archive \isis\inst$\NDXHRPD\Instrument\data\cycle_19_4\HRP78261.nxs.

Suggested solution: create separate manual submission script to scripts/manual_operations/manual_submission.py and call it something manual_submission_without_lookup.py. Look at monitors/run_detection.py and from that get inspiration to submitting jobs without database lookup. Also, consider looking at git history and you might be able to recover an old manual submission scripts which was setup to work this way.

In an ideal world you would not need this, but in practice and as experience today it may be needed, and potentially in critical situations during cycles.

How to test the issue is resolved
Add tests for this script in scripts/manual_operations/tests. Furthermore, test it manually with a number of ISIS runs; note this can be any runs including runs which already exist in database. Write documentation for this manual submission script in scripts/manual_operations/README.md and below the section that explains how operate manual_submission.py works.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions